Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract whitelist tests #200

Open
janpio opened this issue May 27, 2019 · 3 comments · May be fixed by #203
Open

Extract whitelist tests #200

janpio opened this issue May 27, 2019 · 3 comments · May be fixed by #203

Comments

@janpio
Copy link
Member

janpio commented May 27, 2019

This repo contains tests for cordova-plugin-whitelist:
https://github.com/apache/cordova-mobile-spec/tree/master/cordova-plugin-whitelist
https://github.com/apache/cordova-mobile-spec/blob/master/cordova-plugin-mobilespec-tests/tests/whitelist.tests.js

If these still work in any way, it might be worth to extract them to https://github.com/apache/cordova-plugin-whitelist
@janpio
Copy link
Member Author

janpio commented May 27, 2019

Maybe not: The tests referenced here were disabled 3 years ago: 15ef65a

@janpio janpio self-assigned this May 27, 2019
@janpio
Copy link
Member Author

janpio commented May 27, 2019 •
edited
Loading

Turns out these tests work wonderful: apache/cordova-plugin-whitelist#38

Related: #155

@janpio janpio linked a pull request May 28, 2019 that will close this issue
Open
@janpio
Copy link
Member Author

janpio commented Jun 19, 2019 •
edited
Loading

apache/cordova-plugin-whitelist#38 has been merged, whitelist plugin is running its own tests now.

We have to finish this on mobile-spec side now by merging #203 and thus closing this issue.

@janpio janpio mentioned this issue Jun 19, 2019
Closed
@janpio janpio removed their assignment Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up plugins (and extract cordova-plugin-whitelist-tests) apache/cordova-mobile-spec
1 participant
@janpio