Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fixes in the Usage UI #10000

Open
wants to merge 2 commits into
base: 4.20
Choose a base branch
from

Conversation

bernardodemarco
Copy link
Collaborator

@bernardodemarco bernardodemarco commented Nov 28, 2024

Description

This PR addresses the following issues related to the Usage UI:

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

  • Usage UI view when the user does not have access to the listUsageServerMetrics, removeRawUsageRecords, generateUsageRecords and listUsageTypes APIs

image

How Has This Been Tested?

  • Verified that users without access to the listUsageServerMetrics, removeRawUsageRecords, generateUsageRecords and listUsageTypes APIs were not able to interact with them through the UI.
  • Verified that the vertical overflow issue was resolved.

@bernardodemarco bernardodemarco changed the base branch from main to 4.20 November 28, 2024 00:47
@bernardodemarco
Copy link
Collaborator Author

@blueorangutan ui

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.80%. Comparing base (c63c7ee) to head (19f2835).

Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #10000      +/-   ##
============================================
- Coverage     15.80%   15.80%   -0.01%     
  Complexity    12586    12586              
============================================
  Files          5627     5627              
  Lines        492343   492348       +5     
  Branches      59694    59696       +2     
============================================
- Hits          77828    77826       -2     
- Misses       405992   405998       +6     
- Partials       8523     8524       +1     
Flag Coverage Δ
uitests 4.04% <ø> (-0.01%) ⬇️
unittests 16.62% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant