Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GCP-BOM to 26.49.0 #32864

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Upgrade GCP-BOM to 26.49.0 #32864

merged 1 commit into from
Nov 20, 2024

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Oct 18, 2024

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Abacn
Copy link
Contributor Author

Abacn commented Oct 18, 2024

Many zetasql nexmark tests fails with

com.google.zetasql.io.grpc.StatusRuntimeException: UNKNOWN
	at com.google.zetasql.io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:262)
	at com.google.zetasql.io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:243)
	at com.google.zetasql.io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:156)
	at com.google.zetasql.ZetaSqlLocalServiceGrpc$ZetaSqlLocalServiceBlockingStub.getLanguageOptions(ZetaSqlLocalServiceGrpc.java:1562)
...
Caused by: java.lang.UnsupportedOperationException
	at com.google.zetasql.io.grpc.netty.AbstractHttp2Headers.iterator(AbstractHttp2Headers.java:500)
	at io.netty.handler.codec.http2.DefaultHttp2ConnectionDecoder$FrameReadListener.onHeadersRead(DefaultHttp2ConnectionDecoder.java:423)

due to netty_version bumped from "4.1.100.Final" to "4.1.110.Final", not compatible with zetasql "2022.04.1" shaded netty version

Similar to grpc/grpc-java#10707

@Abacn
Copy link
Contributor Author

Abacn commented Oct 18, 2024

as of the latest version of zetasql-client: https://mvnrepository.com/artifact/com.google.zetasql/zetasql-client/2024.08.2

it still shades grpc-1.56.0 and io.netty 4.1.87.Final (last updated: 2023.08.1)

@Abacn Abacn marked this pull request as draft October 31, 2024 21:50
@Abacn Abacn mentioned this pull request Nov 15, 2024
3 tasks
@Abacn Abacn marked this pull request as ready for review November 20, 2024 21:08
@Abacn
Copy link
Contributor Author

Abacn commented Nov 20, 2024

testCommit_handlesFailedCommits (org.apache.beam.runners.dataflow.worker.windmill.client.commits.StreamingEngineWorkCommitterTest) failed


expected to contain: CompleteCommit{computationId=computationId-10, shardedKey=0000000000000002, workId=WorkId{cacheToken=1, workToken=10}, status=ABORTED}
but was            : [CompleteCommit{computationId=computationId-6, shardedKey=0000000000000002, ...

not related to this change. Same test passed the first attempt run (where other irrelevant test failed)

@Abacn
Copy link
Contributor Author

Abacn commented Nov 20, 2024

R: @damccorm

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Abacn Abacn merged commit a06454a into apache:master Nov 20, 2024
25 of 27 checks passed
@Abacn Abacn deleted the bumpbom branch November 20, 2024 22:31
Polber pushed a commit to Polber/beam that referenced this pull request Nov 21, 2024
Polber pushed a commit to Polber/beam that referenced this pull request Nov 21, 2024
Polber pushed a commit to Polber/beam that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants