Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Flask to 2.3.3 #44733

Closed
2 tasks done
andrii-korotkov-verkada opened this issue Dec 6, 2024 · 3 comments
Closed
2 tasks done

Upgrade Flask to 2.3.3 #44733

andrii-korotkov-verkada opened this issue Dec 6, 2024 · 3 comments
Labels
area:dependencies Issues related to dependencies problems kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet

Comments

@andrii-korotkov-verkada
Copy link

Description

Right now Flask is pinned to be <2.3

airflow/hatch_build.py

Lines 387 to 390 in 3d421f7

# Flask 2.3 is scheduled to introduce a number of deprecation removals - some of them might be breaking
# for our dependencies - notably `_app_ctx_stack` and `_request_ctx_stack` removals.
# We should remove the limitation after 2.3 is released and our dependencies are updated to handle it
"flask>=2.2.1,<2.3",
. Update this to be <2.4 or <3.

Use case/motivation

This pin makes it pretty hard to use in some environments, such as Bazel-built monorepo with a Flask version higher than that. Also, an upgrade probably needs to happen eventually anyways.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@andrii-korotkov-verkada andrii-korotkov-verkada added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Dec 6, 2024
Copy link

boring-cyborg bot commented Dec 6, 2024

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

@dosubot dosubot bot added the area:dependencies Issues related to dependencies problems label Dec 6, 2024
@potiuk
Copy link
Member

potiuk commented Dec 6, 2024

I am afraid it will not happen.

We are getting rid of flask altogether anyway in Airlfow 3. This limit comes from connexion 2 - latest version 2.14.2 that we are getting rid as well in Airflow 3. One of the reasons is that upgrading to Connexion 3 is non-trivial (#39055 was a massive green PR that nobody had the courage to continue working on), actually it's very hard to migrate because they changed architecture completely, so we are switching to FastAPi. Because it turned out to be easier.

So ... this issue is "won't do"

@potiuk potiuk closed this as completed Dec 6, 2024
@andrii-korotkov-verkada
Copy link
Author

Ah, okay.

We are getting rid of flask altogether anyway in Airlfow 3.

This would work too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dependencies Issues related to dependencies problems kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet
Projects
None yet
Development

No branches or pull requests

2 participants