Skip to content
This repository has been archived by the owner on Jan 4, 2022. It is now read-only.

Impossible to change tag type from pinger to sensor or range test #347

Closed
xhoenner opened this issue Aug 11, 2016 · 4 comments
Closed

Impossible to change tag type from pinger to sensor or range test #347

xhoenner opened this issue Aug 11, 2016 · 4 comments

Comments

@xhoenner
Copy link
Contributor

xhoenner commented Aug 11, 2016

Steps to reproduce

Go to the Tags page and click on the i icon to the left of any tag whose Transmitter Type is listed as 'PINGER' (e.g. for instance A69-1303-62731). Then click on the Edit button.

What happens

Transmitter type 'PINGER' is not listed anywhere, therefore the only option for users to specify that their tag is actually a sensor tag is to click on the Add Sensor button. This will nonetheless create a duplicate as the tag will then be registered as BOTH a pinger and sensor.

What should happen

PINGER should be listed in the table at the bottom of the /tag/show page (similarly to any other sensor or range test type) so that users can click on the i icon on the left and change the tag type without adding a sensor.

@fjaine
Copy link

fjaine commented Sep 28, 2016

List of duplicates created by this issue: #240 (comment)

@xhoenner
Copy link
Contributor Author

While fixing up this issue it would be very useful to add additional constraints to the database and/or web app based on the code space restrictions indicated below so that we don't end up with erroneously assigned tag type (see #240 (comment)) in the future.

9002 sensor only
9004 sensor only
1601 pinger only
9001 pinger only

@fjaine
Copy link

fjaine commented Dec 8, 2016

See #240 for latest updates on code spaces:

The below are correct:
1601 - pinger only
9001 - pinger only
9002 - sensor
9004 - sensor
9006 - sensor (new code space to come out in 2017)
1206 - very old code space. Although valid, 1206 was susceptible to false positives so the FDA analysis routine should be applied to any datasets containing these ID to see if they are false positives.

xhoenner added a commit that referenced this issue Dec 21, 2016
Once deployed #347 can be closed, which will eventually alleviate the duplicates observed in #240
@bhasin85
Copy link
Contributor

Fixed by #361

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants