Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system: Use solana-system-interface symbols #3809

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

system: Use solana-system-interface symbols #3809

wants to merge 7 commits into from

Conversation

febo
Copy link

@febo febo commented Nov 27, 2024

Problem

The system interface is defined on its own dedicated repository, but the code still exists under the program crate.

Summary of Changes

  • Add the solana-system-interface dependency to the workspace
  • Remove the code from thesystem_instruction module on the sdk/program crate
  • Re-exports all symbols from solana-system-interface

@febo febo marked this pull request as ready for review November 28, 2024 00:31
@febo febo requested a review from joncinque November 28, 2024 00:32
kevinheavey
kevinheavey reviewed Nov 28, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinheavey kevinheavey kevinheavey approved these changes

@joncinque joncinque Awaiting requested review from joncinque

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@febo @kevinheavey