-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract message crate #3704
Extract message crate #3704
Conversation
45242b6
to
891e6cc
Compare
891e6cc
to
5cd83a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, just one suggestion to add a test and to revert some changes that might have snuck in. Is this the last of the painful crate extractions from solana-program?
sdk/transaction-error/src/lib.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were these changes intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, for some reason the CI only complained about an unused import in this PR. Maybe the warning wasn't causing any CI to fail. But the warning is real
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, makes sense -- it's unused in target_os = "solana"
, so if you run ./cargo-build-sbf --manifest-path sdk/transaction-error/Cargo.toml
, you'll see that error warning. I'll put in a separate PR for that if that's ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#3742 fixes that and another thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! @yihau can you accept solana-message
?
2bb61f5
to
0d038f7
Compare
automerge label removed due to a CI failure |
0d038f7
to
3d09ffb
Compare
automerge label removed due to a CI failure |
Sorry, can you rebase once more to pick up #3774 ? |
3d09ffb
to
ace0bf6
Compare
automerge label removed due to a CI failure |
Need to figure out some doctest dependency issues |
There's another issue with the cargo build-sbf tests -- since they're using a local solana-program without patching the deps for solana-system-interface, the build pulls in two versions of solana-pubkey / solana-instruction / solana-decode-error. I can push up a fix for this if you like |
Oh yes please, maybe that's it |
d1ba18e
to
6dd02ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the quick rebase!
Problem
solana_program::message
needs to be pulled outSummary of Changes
This uses the solana-system-interface crate so that needs to be published before this can be merged (update: solana-system-interface has been published)