Model errors of create with generate_name
#566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing the precondition on the API error type from
drop_req, we generalize our fault model by including a new type of error: creation request withgenerate_namefails to create the object when all the creation attempts conflict with existing objects. This type of error is non-deterministic because the API server uses a name randomly generated when handling a creation request whosenameis empty andgenerate_nameis in use. We treat it as a transient error and assume that it will eventually disappear. Otherwise, there is no way for controllers that issue creation requests withgenerate_nameto finish reconciliation.