From bcb1e0daa5c866eb5ba496efc7e91e410d81af07 Mon Sep 17 00:00:00 2001 From: lijinke666 Date: Mon, 14 Oct 2024 16:56:31 +0800 Subject: [PATCH 1/5] =?UTF-8?q?fix:=20=E4=BF=AE=E5=A4=8D=E4=B8=8B=E9=92=BB?= =?UTF-8?q?=20icon=20=E4=B8=8D=E5=BA=94=E8=AF=A5=E9=BB=98=E8=AE=A4?= =?UTF-8?q?=E5=85=A8=E9=83=A8=E5=B1=95=E7=A4=BA?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- packages/s2-shared/src/utils/drill-down.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/s2-shared/src/utils/drill-down.ts b/packages/s2-shared/src/utils/drill-down.ts index f030bfc7b6..22b3e82b19 100644 --- a/packages/s2-shared/src/utils/drill-down.ts +++ b/packages/s2-shared/src/utils/drill-down.ts @@ -154,7 +154,7 @@ export const buildDrillDownOptions = >( }, ], belongsCell: 'rowCell', - defaultHide: false, + defaultHide: true, displayCondition: partDrillDown?.displayCondition || defaultPartDrillDownDisplayCondition, }; From e7a642c4cd99c0e0d9f286a269d5e76128b0e196 Mon Sep 17 00:00:00 2001 From: lijinke666 Date: Mon, 14 Oct 2024 17:26:37 +0800 Subject: [PATCH 2/5] =?UTF-8?q?fix:=20=E4=BF=AE=E5=A4=8D=E4=B8=8B=E9=92=BB?= =?UTF-8?q?=E9=9D=A2=E6=9D=BF=E6=A0=87=E9=A2=98=E4=B8=8D=E5=B1=95=E7=A4=BA?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- packages/s2-react/playground/drill-down.tsx | 2 +- packages/s2-shared/src/styles/drill-down.less | 6 +----- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/packages/s2-react/playground/drill-down.tsx b/packages/s2-react/playground/drill-down.tsx index 88b87355f3..44fa15e0ae 100644 --- a/packages/s2-react/playground/drill-down.tsx +++ b/packages/s2-react/playground/drill-down.tsx @@ -23,7 +23,7 @@ export const partDrillDown: PartDrillDown = { type: 'text', }, ], - extra:
test
, + extra:
test
, }, // drillItemsNum: 1, fetchData: (meta, drillFields) => diff --git a/packages/s2-shared/src/styles/drill-down.less b/packages/s2-shared/src/styles/drill-down.less index 46d6655c34..40beb64006 100644 --- a/packages/s2-shared/src/styles/drill-down.less +++ b/packages/s2-shared/src/styles/drill-down.less @@ -4,7 +4,7 @@ width: 260px; min-height: 20px; position: relative; - color: var(--antv-s2-font-70, #fff); + color: var(--antv-s2-font-70, rgba(0, 0, 0, 0.9)); &-header { display: flex; @@ -42,10 +42,6 @@ } } - &-extra { - margin: 4px 16px; - } - &-menu { max-height: 314px; overflow: hidden auto; From 68fc0e8517b51e96919a03f3754b6b90ac9ab78c Mon Sep 17 00:00:00 2001 From: lijinke666 Date: Mon, 14 Oct 2024 19:30:14 +0800 Subject: [PATCH 3/5] =?UTF-8?q?fix:=20=E7=A7=BB=E9=99=A4=20extra=20dom=20?= =?UTF-8?q?=E8=8A=82=E7=82=B9?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- packages/s2-react/src/components/drill-down/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/s2-react/src/components/drill-down/index.tsx b/packages/s2-react/src/components/drill-down/index.tsx index a6f9f25bf5..f1460d015f 100644 --- a/packages/s2-react/src/components/drill-down/index.tsx +++ b/packages/s2-react/src/components/drill-down/index.tsx @@ -122,13 +122,13 @@ export const DrillDown: React.FC = React.memo( prefix={} allowClear /> -
{extra}
{isEmpty(options) && ( )} + {extra} Date: Tue, 15 Oct 2024 14:01:35 +0800 Subject: [PATCH 4/5] =?UTF-8?q?test:=20=E6=9B=B4=E6=96=B0=E5=BF=AB?= =?UTF-8?q?=E7=85=A7?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../__tests__/unit/utils/__snapshots__/drill-down-spec.ts.snap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/s2-shared/__tests__/unit/utils/__snapshots__/drill-down-spec.ts.snap b/packages/s2-shared/__tests__/unit/utils/__snapshots__/drill-down-spec.ts.snap index 92dae3708f..2348751b3c 100644 --- a/packages/s2-shared/__tests__/unit/utils/__snapshots__/drill-down-spec.ts.snap +++ b/packages/s2-shared/__tests__/unit/utils/__snapshots__/drill-down-spec.ts.snap @@ -11,7 +11,7 @@ Object { "headerActionIcons": Array [ Object { "belongsCell": "rowCell", - "defaultHide": false, + "defaultHide": true, "displayCondition": [Function], "icons": Array [ Object { From 4425a6ae427bc5fec5b7d9acf67d04932e911c51 Mon Sep 17 00:00:00 2001 From: lijinke666 Date: Tue, 15 Oct 2024 15:03:46 +0800 Subject: [PATCH 5/5] =?UTF-8?q?test:=20=E6=9B=B4=E6=96=B0=E5=BF=AB?= =?UTF-8?q?=E7=85=A7?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../components/drill-down/__snapshots__/index-spec.tsx.snap | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/packages/s2-react/__tests__/unit/components/drill-down/__snapshots__/index-spec.tsx.snap b/packages/s2-react/__tests__/unit/components/drill-down/__snapshots__/index-spec.tsx.snap index f59965b5f9..df113f3937 100644 --- a/packages/s2-react/__tests__/unit/components/drill-down/__snapshots__/index-spec.tsx.snap +++ b/packages/s2-react/__tests__/unit/components/drill-down/__snapshots__/index-spec.tsx.snap @@ -66,11 +66,6 @@ exports[`DrillDown Component Tests should render component 1`] = ` -
- extra -
@@ -144,6 +139,7 @@ exports[`DrillDown Component Tests should render component 1`] = ` No data
+ extra