Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复 Safari 浏览器复制/导出报错 #3050

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Conversation

lijinke666
Copy link
Member

👀 PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

  • Solve the issue and close #0

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

Safari 不支持 requestIdleCallback

image

🖼️ Screenshot

Before After

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Dec 24, 2024 7:09am

Copy link
Contributor

你好 @lijinke666,非常感谢你的贡献.
为了让代码更健壮, 请根据 贡献指南 补充相应单元测试 (文档改动或其他特殊场景除外), 如果有 API 改动, 请修改 相应的文档.
同时请检查 linttest 相关 CI 是否通过, 如果失败, 请点击 [Details] 按钮查看, 并根据日志修复.

Hello, @lijinke666, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes.
At the same time, please check whether the CI related to lint and test passes. If the CI fails, please click [Details] button to check and repair according to the log.

@github-actions github-actions bot added pr(fix) bug fix next 2.0-next 版本的问题 labels Dec 24, 2024
@github-actions github-actions bot requested a review from wjgogogo December 24, 2024 07:09
Copy link

Walkthrough

此 PR 修复了 Safari 浏览器中由于不支持 requestIdleCallback 导致的复制/导出功能错误。通过引入 isEnableASync 方法,确保在不支持 requestIdleCallback 的浏览器中降级为同步操作。

Changes

文件 描述
base-data-cell-copy.ts, pivot-data-cell-copy.ts, table-copy.ts 添加了 isEnableASync 方法,用于检查浏览器是否支持 requestIdleCallback,并根据结果决定是否进行异步操作。
copy-export.zh.md 更新了文档,说明在不支持 requestIdleCallback 的浏览器中会强制降级为同步。

/**
* Safari 等不支持 requestIdleCallback 的浏览器, 降级为同步
*/
protected isEnableASync() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

引入 isEnableASync 方法是一个很好的改进,确保了在不支持 requestIdleCallback 的浏览器中能够正常降级为同步操作,避免了潜在的错误。

@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.77%. Comparing base (ecdc9c8) to head (ec33e0b).
Report is 575 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3050      +/-   ##
==========================================
  Coverage   75.77%   75.77%              
==========================================
  Files         257       51     -206     
  Lines       11994     1490   -10504     
  Branches     2464      284    -2180     
==========================================
- Hits         9088     1129    -7959     
+ Misses       1398      210    -1188     
+ Partials     1508      151    -1357     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Size Change: +67 B (+0.01%)

Total Size: 619 kB

Filename Size Change
./packages/s2-core/dist/s2-extends.min.js 154 kB +35 B (+0.02%)
./packages/s2-core/dist/s2.min.js 257 kB +32 B (+0.01%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/s2.min.css 581 B
./packages/s2-react-components/dist/s2-react-components.min.css 2.55 kB
./packages/s2-react-components/dist/s2-react-components.min.js 124 kB
./packages/s2-react/dist/s2-react.min.css 1.74 kB
./packages/s2-react/dist/s2-react.min.js 38.3 kB
./packages/s2-vue/dist/s2-vue.min.css 2.05 kB
./packages/s2-vue/dist/s2-vue.min.js 38.3 kB

compressed-size-action

@lijinke666 lijinke666 merged commit da7d9e5 into next Dec 24, 2024
14 of 16 checks passed
@lijinke666 lijinke666 deleted the fix-safari-export branch December 24, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants