-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 修复 Safari 浏览器复制/导出报错 #3050
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
你好 @lijinke666,非常感谢你的贡献. Hello, @lijinke666, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes. |
Walkthrough此 PR 修复了 Safari 浏览器中由于不支持 Changes
|
/** | ||
* Safari 等不支持 requestIdleCallback 的浏览器, 降级为同步 | ||
*/ | ||
protected isEnableASync() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
引入 isEnableASync
方法是一个很好的改进,确保了在不支持 requestIdleCallback
的浏览器中能够正常降级为同步操作,避免了潜在的错误。
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3050 +/- ##
==========================================
Coverage 75.77% 75.77%
==========================================
Files 257 51 -206
Lines 11994 1490 -10504
Branches 2464 284 -2180
==========================================
- Hits 9088 1129 -7959
+ Misses 1398 210 -1188
+ Partials 1508 151 -1357 ☔ View full report in Codecov by Sentry. |
Size Change: +67 B (+0.01%) Total Size: 619 kB
ℹ️ View Unchanged
|
👀 PR includes
✨ Feature
🎨 Enhance
🐛 Bugfix
🔧 Chore
📝 Description
Safari 不支持 requestIdleCallback
🖼️ Screenshot
🔗 Related issue link
🔍 Self-Check before the merge