Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复自定义列宽对虚拟数值列不生效 #2921

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Conversation

lijinke666
Copy link
Member

👀 PR includes

🐛 Bugfix

  • Solve the issue and close #0

📝 Description

// dataCfg

  "fields": {
    "rows": ["province", "city"],
    "values": ["number"],
  },

// options

  style: {
    colCell: {
      widthByField: {
        number: 100,
      },
    }
  },

🖼️ Screenshot

Before After
image image

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Oct 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Oct 12, 2024 3:20am

@github-actions github-actions bot added next 2.0-next 版本的问题 pr(fix) bug fix labels Oct 12, 2024
Copy link
Contributor

Size Change: +53 B (+0.02%)

Total Size: 329 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 229 kB +53 B (+0.02%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 388 B
./packages/s2-react/dist/index.min.js 70.9 kB
./packages/s2-react/dist/style.min.css 3.88 kB
./packages/s2-vue/dist/index.min.js 22.9 kB
./packages/s2-vue/dist/style.min.css 1.97 kB

compressed-size-action

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.81%. Comparing base (ecdc9c8) to head (291420d).
Report is 445 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2921      +/-   ##
==========================================
+ Coverage   75.77%   80.81%   +5.04%     
==========================================
  Files         257      180      -77     
  Lines       11994    10425    -1569     
  Branches     2464     2362     -102     
==========================================
- Hits         9088     8425     -663     
+ Misses       1398      555     -843     
+ Partials     1508     1445      -63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lijinke666 lijinke666 merged commit c53cea4 into next Oct 12, 2024
12 of 13 checks passed
@lijinke666 lijinke666 deleted the fix-col-style branch October 12, 2024 10:04
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.0-next.29 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-react-v2.0.0-next.28 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants