Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 角头选中列兼容树状模式和自定义行头场景 #2562

Merged
merged 5 commits into from
Feb 29, 2024

Conversation

lijinke666
Copy link
Member

👀 PR includes

🐛 Bugfix

  • Solve the issue and close #0

📝 Description

  • 修复树状模式下, 点击角头时行头未选中.
  • 修复自定义行头下, 点击角头只选中了第一个单元格.

🖼️ Screenshot

Before After
Kapture 2024-02-26 at 15 32 44 Kapture 2024-02-26 at 15 30 16
Kapture 2024-02-26 at 15 33 35 Kapture 2024-02-26 at 15 31 15

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Feb 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Feb 29, 2024 8:52am

@github-actions github-actions bot added pr(fix) bug fix next 2.0-next 版本的问题 labels Feb 26, 2024
Copy link
Contributor

github-actions bot commented Feb 26, 2024

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Feb 26, 2024
Copy link
Contributor

github-actions bot commented Feb 26, 2024

Size Change: +107 B (0%)

Total Size: 317 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 221 kB +107 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 402 B
./packages/s2-react/dist/index.min.js 68.7 kB
./packages/s2-react/dist/style.min.css 4.01 kB
./packages/s2-vue/dist/index.min.js 20.2 kB
./packages/s2-vue/dist/style.min.css 1.98 kB

compressed-size-action

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 78.28%. Comparing base (ecdc9c8) to head (039211d).
Report is 257 commits behind head on next.

Files Patch % Lines
...action/base-interaction/click/corner-cell-click.ts 81.81% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2562      +/-   ##
==========================================
+ Coverage   75.77%   78.28%   +2.51%     
==========================================
  Files         257      275      +18     
  Lines       11994    12483     +489     
  Branches     2464     2541      +77     
==========================================
+ Hits         9088     9772     +684     
+ Misses       1398     1148     -250     
- Partials     1508     1563      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lijinke666 lijinke666 enabled auto-merge (squash) February 29, 2024 08:47
@lijinke666 lijinke666 disabled auto-merge February 29, 2024 09:18
@lijinke666 lijinke666 merged commit 49ad04d into next Feb 29, 2024
7 of 9 checks passed
@lijinke666 lijinke666 deleted the fix-corner-selection branch February 29, 2024 09:18
@github-actions github-actions bot removed the 🚨 test failed 单元测试挂了 label Feb 29, 2024
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.0-next.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants