-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(perf): 去除初始化时,多余的 drilldown 渲染链路 #2446
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lijinke666
reviewed
Dec 4, 2023
lijinke666
approved these changes
Dec 4, 2023
🎉 This PR is included in version @antv/s2-v1.53.0-alpha.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Size Change: +4 B (0%) Total Size: 441 kB
ℹ️ View Unchanged
|
🎉 This PR is included in version @antv/s2-v1.54.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
wjgogogo
added a commit
that referenced
this pull request
Dec 13, 2023
* feat(perf): 去除初始化时,多余的 drilldown 渲染链路 * test: 增加单测 * refactor: 优化 mock 方式
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👀 PR includes
✨ Feature
🎨 Enhance
🐛 Bugfix
🔧 Chore
📝 Description
🖼️ Screenshot
当传入 drilldown 相关参数时,初始化会多一次无效的的 drilldown 渲染。如果数据量比较大时,会多接近一倍的差距。如果 本身就没有生成 drilldown 的结构时,可以避免这次渲染
🔗 Related issue link
🔍 Self-Check before the merge