-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 修复 React 18 StrictMode 同时挂载两个表格的问题 #2432
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。 Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it. |
Size Change: +60 B (0%) Total Size: 311 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2432 +/- ##
==========================================
+ Coverage 75.77% 77.74% +1.97%
==========================================
Files 257 270 +13
Lines 11994 12047 +53
Branches 2464 2443 -21
==========================================
+ Hits 9088 9366 +278
+ Misses 1398 1169 -229
- Partials 1508 1512 +4 ☔ View full report in Codecov by Sentry. |
🎉 This PR is included in version @antv/s2-react-v2.0.0-next.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
👀 PR includes
🐛 Bugfix
📝 Description
React 18 StrictMode 在非生产环境下会强制执行两次, 导致会挂载两个 canvas, 体验不是很好
🖼️ Screenshot
🔗 Related issue link
#2373 遗留问题
🔍 Self-Check before the merge