feat: 编辑表格新增拖拽填充功能 #1858

bealish-992 · 2022-10-27T09:25:22Z

👀 PR includes

✨ Feature

New feature

📝 Description

编辑表格新增拖拽填充。点击数值单元格右下角出现可拖拽标识，拖拽选择区域进行内容填充。

🖼️ Screenshot

Before	After
❌	✅

🔗 Related issue link

ref: #1811

🔍 Self-Check before the merge

Add or update relevant docs.
Add or update relevant demos.
Add or update test case.
Add or update relevant TypeScript definitions.

vercel · 2022-10-27T09:25:27Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
antvis-s2	❌ Failed (Inspect)		Nov 21, 2022 at 7:54AM (UTC)

lgtm-com · 2022-10-27T09:34:46Z

This pull request introduces 4 alerts when merging ece9c3a into 025359d - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class
1 for Useless assignment to local variable
1 for Comparison between inconvertible types

codecov · 2022-10-27T10:00:26Z

Codecov Report

Base: 77.16% // Head: 76.62% // Decreases project coverage by -0.53% ⚠️

Coverage data is based on head (a068de2) compared to base (a4b14a8).
Patch coverage: 61.15% of modified lines in pull request are covered.

❗ Current head a068de2 differs from pull request most recent head b25782d. Consider uploading reports for the commit b25782d to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1858      +/-   ##
==========================================
- Coverage   77.16%   76.62%   -0.54%     
==========================================
  Files         234      240       +6     
  Lines       11518    12062     +544     
  Branches     2449     2559     +110     
==========================================
+ Hits         8888     9243     +355     
- Misses       1258     1368     +110     
- Partials     1372     1451      +79

Impacted Files	Coverage Δ
packages/s2-core/src/facet/layout/node.ts	`64.04% <ø> (+1.69%)`	⬆️
packages/s2-core/src/sheet-type/pivot-sheet.ts	`86.11% <0.00%> (ø)`
packages/s2-core/src/sheet-type/table-sheet.ts	`87.93% <ø> (ø)`
packages/s2-core/src/utils/hide-columns.ts	`83.87% <ø> (+0.35%)`	⬆️
...ages/s2-core/src/utils/interaction/select-event.ts	`93.61% <ø> (ø)`
packages/s2-core/src/utils/merge.ts	`90.32% <ø> (ø)`
packages/s2-core/src/utils/number-calculate.ts	`81.25% <0.00%> (-1.36%)`	⬇️
...es/s2-react/src/components/advanced-sort/index.tsx	`39.04% <0.00%> (-0.27%)`	⬇️
...s2-react/src/components/tooltip/custom-tooltip.tsx	`64.28% <ø> (-2.39%)`	⬇️
packages/s2-shared/src/utils/drill-down.ts	`21.31% <ø> (ø)`
... and 113 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

lijinke666 · 2022-10-27T10:08:12Z

充值 => 重置 ? 记得 rebase 一下

lijinke666 · 2022-10-27T10:08:52Z

录个 gif 感受下?

github-actions · 2022-10-27T10:09:48Z

你好 @bealish-992，感谢你的贡献, 为了让代码更健壮, 请补充相应单元测试, 如果有 API 改动, 请修改相应的文档

Hello, @bealish-992, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes.

packages/s2-react/src/components/sheets/editable-sheet/drag-copy/DragCopyMask.tsx

packages/s2-react/src/components/sheets/editable-sheet/drag-copy/index.tsx

packages/s2-react/src/components/sheets/editable-sheet/index.tsx

lgtm-com · 2022-10-27T11:04:08Z

This pull request introduces 4 alerts when merging b73ea16 into 025359d - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class
1 for Useless assignment to local variable
1 for Comparison between inconvertible types

lgtm-com · 2022-11-16T06:46:43Z

This pull request introduces 4 alerts when merging aadc19e into bfe02cb - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class
1 for Useless assignment to local variable
1 for Comparison between inconvertible types

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

lgtm-com · 2022-11-16T07:14:12Z

This pull request introduces 4 alerts when merging e184ed5 into bfe02cb - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class
1 for Useless assignment to local variable
1 for Comparison between inconvertible types

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

lgtm-com · 2022-11-21T02:47:53Z

This pull request introduces 2 alerts when merging 2e194d6 into 47cdbdc - view on LGTM.com

new alerts:

1 for Useless assignment to local variable
1 for Comparison between inconvertible types

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

serializedowen

LG

lgtm-com · 2022-11-21T03:04:24Z

This pull request introduces 2 alerts when merging 568b053 into 47cdbdc - view on LGTM.com

new alerts:

1 for Useless assignment to local variable
1 for Comparison between inconvertible types

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

packages/s2-react/src/components/sheets/editable-sheet/drag-copy/drag-copy-mask.less

packages/s2-react/src/components/sheets/editable-sheet/drag-copy/drag-copy-mask.tsx

packages/s2-react/src/components/sheets/editable-sheet/drag-copy/drag-copy-point.less

packages/s2-react/src/components/sheets/editable-sheet/drag-copy/index.tsx

lgtm-com · 2022-11-21T06:31:35Z

This pull request introduces 2 alerts when merging 84526aa into 5c27914 - view on LGTM.com

new alerts:

1 for Useless assignment to local variable
1 for Comparison between inconvertible types

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

lgtm-com · 2022-11-21T07:00:53Z

This pull request introduces 2 alerts when merging a068de2 into 5c27914 - view on LGTM.com

new alerts:

1 for Useless assignment to local variable
1 for Comparison between inconvertible types

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

xingwanying

LG

lgtm-com · 2022-11-21T07:58:30Z

This pull request introduces 2 alerts when merging b25782d into c9bc47c - view on LGTM.com

new alerts:

1 for Useless assignment to local variable
1 for Comparison between inconvertible types

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

lijinke666 · 2022-11-21T10:08:32Z

🎉 This PR is included in version @antv/s2-react-v1.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

* docs: 优化 Issues/PR 模板 (#1903) docs: 优化 Issue/PR 模板 * fix: 修复sortedDimensionValues过滤不正确而导致的排序错乱的问题 (#1908) * fix: 修复圈选偏移问题 (#1883) * refactor: 使用矩形相交算法来实现圈选功能 * fix: 修复滚动后刷选偏移问题 * refactor: 区分 data brush 和 base brush 的单测 * test: 添加列头单测 * refactor: 使用矩形相交算法来实现行头圈选功能 * test: 行头圈选功能单测更新 * chore: 删除无用的属性 headerY、headerX * fix(interaction): 修复多列头多指标场景下隐藏列头错误 close #1721 (#1905) * fix(interaction): 修复多列头多指标场景下隐藏列头错误 close #1721 * docs: 文档 * docs: 💥 官网迁移 dumi-theme (#1917) * refactor: migrate to dumi-theme-antv from gatsby (#1891) * feat: migrate to dumi-theme-antv from gatsby * delete yarn.lock * format * update: package.json (#1906) * chore: 修复script * chore: 删除无用配置 * chore: 删除无用依赖 * chore: 删除无效配置文件 * docs: 修复新版文档 md 格式 & 润色部分文档 (#1909) * fix: 修复官网样例数据路径问题 (#1910) * chore: 更新官网配置 * fix: 修复官网样例数据路径问题 * feat: master 分支文档，全量翻译为英文 (#1911) * fix: 解决单个IP地址请求过多，导致Google API 报 14 错误问题 * fix: 格式化表格，保证表格的准确性 * feat: 使用 html 翻译脚本 * feat: 解决一系列文本转换的细节问题 * feat: 翻译 basic 下所有文件 * feat: 添加 docs 下除 manual 文件以外的英文文档 * feat: 官网新增在线体验功能 (#1885) * feat: 官网新增在线体验功能 * feat: migrate playground to dumi-theme-antv from gatsby (#1907) * docs: 新增自定义特定单元格示例 (#1887) * docs(theme): 新增透明背景色主题配置示例 (#1886) * docs: 更新README，增加数据洞察 (#1877) * docs: 更新README，增加数据洞察 * docs: 更新readme * refactor: migrate to dumi-theme-antv from gatsby (#1891) * feat: migrate to dumi-theme-antv from gatsby * delete yarn.lock * format * update: package.json Co-authored-by: Jinke Li <[email protected]> Co-authored-by: 嘤嘤嘤 <[email protected]> * chore: 更新playground配置 Co-authored-by: gaofuhong.gfh <[email protected]> Co-authored-by: 洋 <[email protected]> Co-authored-by: Jinke Li <[email protected]> Co-authored-by: 嘤嘤嘤 <[email protected]> * docs: 修复英语文档启动错误的问题 (#1913) * fix: 解决启动报错问题 * docs: 将改动较大的文件重新翻译 * fix: 官网问题走查 (#1915) * fix: 更新官网配置，增加国内镜像链接 * chore: 删除无效代码 * chore: 合并master (#1916) * chore: 添加Markdown 中翻英，自动(google translate API)翻译脚本 (#1893) * feat: add google translate script * feat: 单文件翻译功能完成 * feat: 文件夹整体翻译的功能完成 Co-authored-by: 嘤嘤嘤 <[email protected]> * feat: 完善复制和导出 (#1896) * feat(interaction): 角头有省略号时 hover 后显示 tooltip (#1889) * fix: 修复行头链接跳转时，获取行数据的问题 (#1888) * fix: 修复行头链接跳转时，获取行数据的问题 * test: 修复单测 * test: 更换 row-link 测试方式 * revert: 回退 row-cell 修改 Co-authored-by: Jinke Li <[email protected]> * docs: 优化 Issues/PR 模板 (#1903) docs: 优化 Issue/PR 模板 * fix: 修复sortedDimensionValues过滤不正确而导致的排序错乱的问题 (#1908) * fix: 修复圈选偏移问题 (#1883) * refactor: 使用矩形相交算法来实现圈选功能 * fix: 修复滚动后刷选偏移问题 * refactor: 区分 data brush 和 base brush 的单测 * test: 添加列头单测 * refactor: 使用矩形相交算法来实现行头圈选功能 * test: 行头圈选功能单测更新 * chore: 删除无用的属性 headerY、headerX * fix(interaction): 修复多列头多指标场景下隐藏列头错误 close #1721 (#1905) * fix(interaction): 修复多列头多指标场景下隐藏列头错误 close #1721 * docs: 文档 * chore: update the yarn.lock Co-authored-by: stone <[email protected]> Co-authored-by: Jinke Li <[email protected]> Co-authored-by: Wenjun Xu <[email protected]> * chore: 添加 CNAME Co-authored-by: 洋 <[email protected]> Co-authored-by: Jinke Li <[email protected]> Co-authored-by: stone <[email protected]> Co-authored-by: GaoFuhong <[email protected]> Co-authored-by: gaofuhong.gfh <[email protected]> Co-authored-by: Wenjun Xu <[email protected]> * feat: 明细表支持多级表头 (#1921) * feat: 明细表支持多级表头(cheery-pick #1687) * fix: 明细表多级表头固定多行和多列后数据和界面渲染不正确 (cheery-pick #1801) * chore: 删除官网无用样例数据 Co-authored-by: zeyong tsai <[email protected]> * chore: 修复明细表多列头下无数据展示 (#1923) * docs: 修复官网部分展示问题 (#1925) fix: 修复官网部分展示问题 * feat: 编辑表格新增拖拽填充功能 (#1858) * [#1811]编辑表格支持拖拽填充值 * fix: 修改文件命名&pr问题修改 * fix: 变量移出 * fix: import 顺序 * fix: import 顺序 * chore: 清除无用代码 * fix: ci问题 * fix: ci问题 * fix: css问题 Co-authored-by: wb-zwa900731 <[email protected]> Co-authored-by: owen.wjh <[email protected]> Co-authored-by: serializedowen <[email protected]> Co-authored-by: 嘤嘤嘤 <[email protected]> * docs: 添加 mini 图相关文档 (#1927) docs: 增加 mini 图相关文档 * feat: 补充英文文档 (#1930) * docs: dumi版官网文档走查 (#1926) * docs: dumi版官网文档走查 * docs: 全局替换链接路径 * fix(docs): docs api update * fix(docs): docs api update * chore: 更新 dumi-theme-antv 版本 * docs: 更新 readme 官网地址 * chore: 删除 yarn.lock Co-authored-by: wengyidong.wyd <[email protected]> Co-authored-by: 嘤嘤嘤 <[email protected]> * docs: 更新过期包厢二维码 (#1932) * chore: 删除国内镜像同步 * docs: 更新过期二维码 * fix: playground not work (#1934) Co-authored-by: 逍为 <[email protected]> * fix: 修复编辑表格数据获取问题 (#1936) * docs: 修复部分 API 文档显示错误 (#1937) * style: 更新官网首页样式 (#1938) * chore: 优化自动发布 CI (#1942) Co-authored-by: Wenjun Xu <[email protected]> Co-authored-by: stone <[email protected]> Co-authored-by: 嘤嘤嘤 <[email protected]> Co-authored-by: 洋 <[email protected]> Co-authored-by: GaoFuhong <[email protected]> Co-authored-by: gaofuhong.gfh <[email protected]> Co-authored-by: zeyong tsai <[email protected]> Co-authored-by: 张燊 <[email protected]> Co-authored-by: wb-zwa900731 <[email protected]> Co-authored-by: owen.wjh <[email protected]> Co-authored-by: serializedowen <[email protected]> Co-authored-by: wengyidong.wyd <[email protected]> Co-authored-by: hustcc <[email protected]> Co-authored-by: 逍为 <[email protected]>

lijinke666 · 2022-11-25T07:51:44Z

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

* [#1811]编辑表格支持拖拽填充值 * fix: 修改文件命名&pr问题修改 * fix: 变量移出 * fix: import 顺序 * fix: import 顺序 * chore: 清除无用代码 * fix: ci问题 * fix: ci问题 * fix: css问题 Co-authored-by: wb-zwa900731 <[email protected]> Co-authored-by: owen.wjh <[email protected]> Co-authored-by: serializedowen <[email protected]> Co-authored-by: 嘤嘤嘤 <[email protected]>

keer6 · 2023-11-15T07:53:13Z

这个功能没有个开关吗？

[antvis#1811]编辑表格支持拖拽填充值

ece9c3a

github-actions bot added the pr(feature) new feature label Oct 27, 2022

github-actions bot assigned bealish-992 Oct 27, 2022

github-actions bot requested review from GaoFuhong, lcx-seima, lijinke666, serializedowen, stone-lyl, wjgogogo, xingwanying and YardWill October 27, 2022 09:25

vercel bot deployed to Preview October 27, 2022 09:35 View deployment

lijinke666 added the 🙏 need test cases or docs 需要单元测试或者补充文档 label Oct 27, 2022

lijinke666 reviewed Oct 27, 2022

View reviewed changes

bealish-992 changed the title ~~feat: 编辑表格新增拖拽填充值功能~~ feat: 编辑表格新增拖拽填充功能 Oct 27, 2022

fix: 修改文件命名&pr问题修改

b73ea16

vercel bot deployed to Preview October 27, 2022 11:05 View deployment

fix: 变量移出

aadc19e

vercel bot had a problem deploying to Preview November 16, 2022 06:46 Failure

fix: import 顺序

e184ed5

vercel bot had a problem deploying to Preview November 16, 2022 07:14 Failure

vercel bot had a problem deploying to Preview November 21, 2022 02:23 Failure

serializedowen reviewed Nov 21, 2022

View reviewed changes

serializedowen previously approved these changes Nov 21, 2022

View reviewed changes

Merge branch 'master' into master

568b053

vercel bot had a problem deploying to Preview November 21, 2022 03:00 Failure

lijinke666 reviewed Nov 21, 2022

View reviewed changes

packages/s2-react/src/components/sheets/editable-sheet/drag-copy/drag-copy-mask.less Outdated Show resolved Hide resolved

lijinke666 reviewed Nov 21, 2022

View reviewed changes

packages/s2-react/src/components/sheets/editable-sheet/drag-copy/drag-copy-mask.tsx Outdated Show resolved Hide resolved

lijinke666 reviewed Nov 21, 2022

View reviewed changes

fix: css问题

84526aa

serializedowen dismissed their stale review via 84526aa November 21, 2022 06:21

vercel bot had a problem deploying to Preview November 21, 2022 06:24 Failure

Merge branch 'master' into master

a068de2

vercel bot had a problem deploying to Preview November 21, 2022 06:56 Failure

serializedowen enabled auto-merge (squash) November 21, 2022 07:31

Merge branch 'master' into master

b25782d

xingwanying approved these changes Nov 21, 2022

View reviewed changes

vercel bot had a problem deploying to Preview November 21, 2022 07:54 Failure

serializedowen merged commit c607d55 into antvis:master Nov 21, 2022

lijinke666 added the released label Nov 21, 2022

lcx-seima mentioned this pull request Dec 5, 2022

🙏编辑表格支持拖拽填充值 #1811

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: 编辑表格新增拖拽填充功能 #1858

feat: 编辑表格新增拖拽填充功能 #1858

bealish-992 commented Oct 27, 2022 •

edited by serializedowen

Loading

vercel bot commented Oct 27, 2022 •

edited

Loading

lgtm-com bot commented Oct 27, 2022

codecov bot commented Oct 27, 2022 •

edited

Loading

lijinke666 commented Oct 27, 2022

lijinke666 commented Oct 27, 2022

github-actions bot commented Oct 27, 2022

lgtm-com bot commented Oct 27, 2022

lgtm-com bot commented Nov 16, 2022

lgtm-com bot commented Nov 16, 2022

lgtm-com bot commented Nov 21, 2022

serializedowen left a comment

lgtm-com bot commented Nov 21, 2022

lgtm-com bot commented Nov 21, 2022

lgtm-com bot commented Nov 21, 2022

xingwanying left a comment

lgtm-com bot commented Nov 21, 2022

lijinke666 commented Nov 21, 2022

lijinke666 commented Nov 25, 2022

keer6 commented Nov 15, 2023

feat: 编辑表格新增拖拽填充功能 #1858

feat: 编辑表格新增拖拽填充功能 #1858

Conversation

bealish-992 commented Oct 27, 2022 • edited by serializedowen Loading

👀 PR includes

📝 Description

🖼️ Screenshot

🔗 Related issue link

🔍 Self-Check before the merge

vercel bot commented Oct 27, 2022 • edited Loading

lgtm-com bot commented Oct 27, 2022

codecov bot commented Oct 27, 2022 • edited Loading

Codecov Report

lijinke666 commented Oct 27, 2022

lijinke666 commented Oct 27, 2022

github-actions bot commented Oct 27, 2022

lgtm-com bot commented Oct 27, 2022

lgtm-com bot commented Nov 16, 2022

lgtm-com bot commented Nov 16, 2022

lgtm-com bot commented Nov 21, 2022

serializedowen left a comment

Choose a reason for hiding this comment

lgtm-com bot commented Nov 21, 2022

lgtm-com bot commented Nov 21, 2022

lgtm-com bot commented Nov 21, 2022

xingwanying left a comment

Choose a reason for hiding this comment

lgtm-com bot commented Nov 21, 2022

lijinke666 commented Nov 21, 2022

lijinke666 commented Nov 25, 2022

keer6 commented Nov 15, 2023

bealish-992 commented Oct 27, 2022 •

edited by serializedowen

Loading

vercel bot commented Oct 27, 2022 •

edited

Loading

codecov bot commented Oct 27, 2022 •

edited

Loading