Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🙏期望@antv/s2-react能兼容react18 #1518

Closed
chenchengwork opened this issue Jul 4, 2022 · 3 comments
Closed

🙏期望@antv/s2-react能兼容react18 #1518

chenchengwork opened this issue Jul 4, 2022 · 3 comments
Labels
🙏feature request 新需求支持 💤 inactive 不活跃的 Issue 或 PR, 30天没有回复 s2-react React 组件层问题 ⭐️ Welcom PR 需求合理, 但是优先级特别低, 近期不会开发, 欢迎社区共建, 提交PR

Comments

@chenchengwork
Copy link

🏷 Version

Package Version
@antv/s2 1.22.0
@antv/s2-react 1.20.0

🖋 Description

Warning: ReactDOM.render is no longer supported in React 18. Use createRoot instead. Until you switch to the new API, your app will behave as if it's running React 17. Learn more: https://reactjs.org/link/switch-to-createroot

@chenchengwork chenchengwork added the 🙏feature request 新需求支持 label Jul 4, 2022
@lijinke666 lijinke666 added the ⭐️ Welcom PR 需求合理, 但是优先级特别低, 近期不会开发, 欢迎社区共建, 提交PR label Jul 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

你好 @chenchengwork,经过我们的反复讨论, 你的需求现已被采纳, 我们会排期开发, 但人力资源有限, 短期内无法支持, 请关注后续发布日志。当然, 如果能贡献 PR 帮助我们改进, 不胜感激!

Hello, @, your feature request has been accepted after our repeated discussion. We will schedule the development. However, it could not be supported in the short term since limited time, please pay attention to the follow-up release logs. Of course, looking forward for your PR!

@lijinke666 lijinke666 added the s2-react React 组件层问题 label Jul 5, 2022
@github-actions github-actions bot added the 💤 inactive 不活跃的 Issue 或 PR, 30天没有回复 label Aug 16, 2022
@astragier
Copy link

Why is the issue inactive while the last commit says the development will be scheduled?

@lijinke666
Copy link
Member

resolved #2373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙏feature request 新需求支持 💤 inactive 不活跃的 Issue 或 PR, 30天没有回复 s2-react React 组件层问题 ⭐️ Welcom PR 需求合理, 但是优先级特别低, 近期不会开发, 欢迎社区共建, 提交PR
Projects
None yet
Development

No branches or pull requests

3 participants