Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drupal - Backerymails] - Refactoring & Migrations #16

Open
WengerK opened this issue Dec 20, 2019 · 1 comment · May be fixed by #18 or #43
Open

[Drupal - Backerymails] - Refactoring & Migrations #16

WengerK opened this issue Dec 20, 2019 · 1 comment · May be fixed by #18 or #43
Assignees

Comments

@WengerK
Copy link
Member

WengerK commented Dec 20, 2019

Description de la tâche

  • Renommer la table pour supprimer la faute d'ortographe.
  • Ajouter un UpdatePathTestBase avec copie des anciennes data vers la nouvelle table.
  • Utiliser une transaction pour la copie.
  • Utiliser 1 seul hook_update pour l'insertion et la suppression de l'ancienne table.

Attention à tests les point suivants dans UpdatePathTestBase

  • Tester que toutes les éléments de l'ancienne table sont bien dans la nouvelle.
  • Tester que l'autoincrement marchent toujours (normalement oui).
  • Summary: 2 tests
    • Y avait rien dans la nouvelle table donc tout est nouveau
    • Y avait des trucs dans la nouvelle table

Temps
5h

@WengerK WengerK self-assigned this May 1, 2020
@WengerK WengerK linked a pull request May 1, 2020 that will close this issue
@WengerK WengerK linked a pull request May 1, 2020 that will close this issue
@WengerK WengerK assigned yannlugrin, gido and StevenAvelino24 and unassigned WengerK May 1, 2020
@WengerK
Copy link
Member Author

WengerK commented May 1, 2020

I need a review from people using this module, as I want them to be aware of the changes I made here - if one day they encounter any error created from this PR.

It's also a good start for people to see how to create UpgradePathTests which are pretty difficulte to tests by yourself (update database and reset number of hook_update takes sooooo much time, coding an UpdateTests accelerate the code process in my opinion).

@WengerK WengerK linked a pull request Jul 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment