fix(Popover): autoUpdate not working when defaultVisible is false #6795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Deploying ant-design-mobile with
|
| Latest commit: |
679e974
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4fc2ec97.ant-design-mobile.pages.dev |
| Branch Preview URL: | https://popover-dynamic.ant-design-mobile.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6795 +/- ##
=======================================
Coverage 92.72% 92.72%
=======================================
Files 335 335
Lines 7198 7198
Branches 1804 1767 -37
=======================================
Hits 6674 6674
- Misses 489 516 +27
+ Partials 35 8 -27 ☔ View full report in Codecov by Sentry. |
|
Size Change: -18 B (0%) Total Size: 370 kB
ℹ️ View Unchanged
|
size-limit report 📦
|
zombieJ
reviewed
Dec 10, 2024
| @@ -187,11 +187,11 @@ export const Popover = forwardRef<PopoverRef, PopoverProps>((p, ref) => { | |||
|
|
|||
| useEffect(() => { | |||
| const floatingElement = floatingRef.current | |||
| if (!targetElement || !floatingElement) return | |||
| if (!targetElement || !floatingElement || !visible) return | |||
zombieJ
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autoUpdate 在 visible 变化时触发，visible 为 false 关闭 autoUpdate，visible 为 true 开启 autoUpdate。一方面可以优化运行时性能，另一方面可以解决默认 visible = false 时，元素未创建，导致 autoUpdate 不生效的问题。
Fix #6794