Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuxt configKey is wrong, error on run, and doesn't run on dev process #50

Closed
6 of 9 tasks
gridsystem opened this issue Aug 1, 2024 · 5 comments
Closed
6 of 9 tasks
Labels
bot: closed c: bug Something isn't working Stale

Comments

@gridsystem
Copy link

Pre-Checks

Describe the bug

  1. your Nuxt module configKey is set to openapi-jsdoc-compiler instead of faviconsPlugin which you've used for other frameworks/builders. See the Nuxt Google Fonts module for an example of Nuxt's two different config formats, one of which uses this configKey as a key.

  2. When using this config, and running pnpm build, I get the error ERROR Nuxt Build Error: [@anolilab/unplugin-favicons] The "path" argument must be of type string or an instance of Buffer or URL. Received undefined

'openapi-jsdoc-compiler': {
	logo: '/assets/logo.svg', // or png produces the same error
	appName: 'redacted',
	developerName: 'redacted',
	developerURL: 'redacted',
	background: '#bada55',
	theme_color: '#c0ff33',
	icons: {
		windows: false,
		yandex: false
	}
}
  1. Nothing happens at all when running pnpm dev, which is the local development server. It would be nice if the module worked with this to preview the results during the standard dev process instead of pnpm build which is the production build process.

I'm sorry I haven't followed the bug report format, I'm working on a project and have limited time. This looks like a great project though and you should submit it to the Nuxt modules directory!

As an aside, unplugFavicon would make a great module name instead of the more generic faviconsPlugin.

Minimal reproduction code

No response

Additional Context

No response

Environment Info

sh: envinfo: command not found

Which module system do you use?

  • CJS
  • ESM

Used Package Manager

pnpm

@gridsystem gridsystem added c: bug Something isn't working s: pending triage Pending Triage labels Aug 1, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

It looks like this is your first issue. Welcome! 👋 One of the project maintainers will be with you as soon as possible. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

@prisis
Copy link
Member

prisis commented Aug 6, 2024

Hey @gridsystem, thank you for the bug report :)

Point 1 and 2 will be fixed with #51

For point 3, need a bit more time to find a good way to do it

@prisis prisis removed the s: pending triage Pending Triage label Aug 6, 2024
@prisis
Copy link
Member

prisis commented Aug 6, 2024

version 1.0.4 will have a working nuxt intigration :)

Copy link
Contributor

This issue has been automatically marked as stale because it has been open for 21 days with no activity. It will be closed in 7 days if no further activity (Remove label or comment) occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of this project. 🙏

@github-actions github-actions bot added the Stale label Aug 28, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 4, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using our GitHub Discussions tab for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot: closed c: bug Something isn't working Stale
Projects
None yet
Development

No branches or pull requests

2 participants