Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fragment_shared_decks_download.xml #17527

Closed
wants to merge 1 commit into from

Conversation

DevNishantHub
Copy link

Add a "Download Manually" Button in the Layout Add a button to the XML layout for the fragment. For example, in fragment_shared_decks_download.xml

Purpose / Description

Describe the problem or feature and motivation

Fixes

  • Fixes #

Approach

How does this change address the problem?

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration (SDK version(s), emulator or physical, etc)

Learning (optional, can help others)

Describe the research stage

Links to blog posts, patterns, libraries or addons used to solve this problem

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Add a "Download Manually" Button in the Layout Add a button to the XML layout for the fragment. For example, in fragment_shared_decks_download.xml
Copy link

welcome bot commented Dec 1, 2024

First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible.

@mikehardy mikehardy marked this pull request as draft December 1, 2024 15:19
@mikehardy
Copy link
Member

Hi @DevNishantHub 👋 ! This is not a complete PR I don't think, based on the other two partial PRs also opened at nearly the same time, so I am converting this to a draft.

Please only propose complete PRs and include all the information requested in the PR template, thanks

@lukstbit
Copy link
Member

lukstbit commented Dec 3, 2024

Hey, thank you for trying to contribute.

For issue #17178 there's already an open PR(#17351) which was opened first and will most likely be merged as a fix.

As an alternative issue to contribute to there's #13282(please read the top post there) to get started with our codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants