Handle 'Support older Anki Versions' when exporting

[NameLessGO]

This bug report is crossposted from Anking repo to Ankidroid

• Size difference when exporting Anking note type: Anki vs Ankidroid AnKing-VIP/AnKing-Note-Types#205

[david-allison]

The difference is due to this option being enabled in AnkiDroid by default.

To confirm, enable the option, export on desktop and compare the size with the AnkiDroid export.

• abdo

[david-allison]

This can be implemented in the following file

https://github.com/ankidroid/Anki-Android/blob/09a45359ec70fd76c76d7115b14a4127aea6cc13/AnkiDroid/src/main/java/com/ichi2/anki/export/ExportDialogFragment.kt

Steps

1) remove = true defaults on legacy in the underlying functions

Anki-Android/AnkiDroid/src/main/java/com/ichi2/libanki/BackendImportExport.kt

Lines 114 to 120 in 14813c1

	fun Collection.exportAnkiPackage(
	outPath: String,
	withScheduling: Boolean,
	withDeckConfigs: Boolean,
	withMedia: Boolean,
	limit: ExportLimit,
	legacy: Boolean = true

Anki-Android/AnkiDroid/src/main/java/com/ichi2/libanki/BackendImportExport.kt

Lines 83 to 87 in 14813c1

	fun Collection.exportCollectionPackage(
	outPath: String,
	includeMedia: Boolean,
	legacy: Boolean = true
	) {

2) Add a Checkbox to obtain the user-selected value in the Fragment

Use TR. to obtain the translated string which Anki Desktop uses

Only show the checkbox when either collection/deck exports are selected

3) Ensure the default user-selected value is false for both apkg and colpkg

4) Add appropriate unit tests

Suggestions:

• Checkbox is only available on two selections
• Checkbox defaults to false
• Checkbox value is provided to the correct export functions (true/false)

---

• Reference: Update to work with desktop 2.1.54 code #11644 => b5829f6

[Haz3-jolt]

Hi I'd like to work on this

[Haz3-jolt]

Ok some help with this if possible,

1. What is the user-selected value we are looking for? is it the value for legacy being true or false?
2. For the string, I can't find the relevant string for this? Does it already exist or are we supposed to create it?

[david-allison]

Anki Desktop default is disabled (for both apkg and colpkg). legacy = false is the default.

The string is: TR.exportingSupportOlderAnkiVersions()

[Haz3-jolt]

Cool got it.

[Haz3-jolt]

@david-allison I'm pretty much done implementing the feature except for the unit Tests, I'll have to create a new Unit test file since ExportDialogFragment does not have unit Tests yet. Is it fine to put a @NeedsTest decorator and push in a separate PR?

[david-allison]

Sure! Alternately, you can create the test file in the PR

[Haz3-jolt]

Sure! Got some other work for tomorrow, so might not be able to get to it immediately, but wanted something out so I can get feedback.

[david-allison]

No rush! Your time is greatly appreciated