Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.20, German] Statistics: True Retention overflows screen #17526

Open
david-allison opened this issue Dec 1, 2024 · 9 comments
Open

[2.20, German] Statistics: True Retention overflows screen #17526

david-allison opened this issue Dec 1, 2024 · 9 comments

Comments

@david-allison
Copy link
Member

German locale, 2.20alpha3, statistics page, last table (true retention):

It fits more or less, but you can move it a bit wishing to the left or right. And the title text "Fehlversuche" and "Erfolgsquote" go beyond their column (while the first colomn has even free space):

Image

Originally posted by @sommerluk in #17366 (comment)

@david-allison david-allison added this to the 2.20 Release milestone Dec 1, 2024
@david-allison david-allison changed the title Statistics: True Retention overflows screen [German] [2.20, German] Statistics: True Retention overflows screen Dec 1, 2024
@Aditya13s
Copy link
Contributor

I am working on it.

@david-allison
Copy link
Member Author

@Aditya13s how do you plan to tackle this?


This needs to be done ASAP, so there's a chance it'll conflict if it takes too long

@Aditya13s
Copy link
Contributor

Aditya13s commented Dec 1, 2024

@Aditya13s how do you plan to tackle this?

I’m thinking of decreasing the width percentage of the first column.

@Aditya13s
Copy link
Contributor

Aditya13s commented Dec 1, 2024

colgroup col:first-child { width: 30% }
colgroup col:nth-child(2) { width: 20%; }

These lines make the page look like this. Is this good?
Image

@sommerluk
Copy link

At least for German, that's great. Thank you!

(I've noticed that this is also an upstream issue (in Anki Desktop), thous it is more difficult to trigger there because you can freely resize the window, and most sizes work well.)

@BrayanDSO
Copy link
Member

Reducing the width isn't a universal fix. A user that has the font size increased for accessibility and a smaller device can see the overflow in any language.

I believe that this also applies to AnkiMobile (if the app font should scale with the system's font, if it doesn't, it is an even bigger problem). Anki desktop doesn't scale with Windows font size, so the problem doesn't exist there because of another one.

Anyway, upstream issue, although we are affected.

@mikehardy
Copy link
Member

The page does have fonts go up when you change system font size, and everything goes up when you change display size (both in accessibility) -> I checked

And both blow up the page completely because it's not responsively designed fundamentally - it needs more work than just constraining a table

I do not consider this a 2.20 blocker and move to ignore it for now.

@Aditya13s
Copy link
Contributor

I think that making the table horizontally scrollable could solve the issue.

@ankidroid ankidroid deleted a comment from louzhuqaq Dec 3, 2024
@mikehardy mikehardy modified the milestones: 2.20 Release, 2.21 release Dec 4, 2024
@brishtibheja
Copy link

I have faced text overflow issues for other parts of the screen (even with popular languages like JP).

An example:
Image


The TR table for German will probably look better after ankitects/anki#3640.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants