Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency versions should be consolidated in libs.versions.toml file / ndk version referenced dynamically #405

Open
mikehardy opened this issue Aug 20, 2024 · 1 comment
Labels

Comments

@mikehardy
Copy link
Member

mikehardy commented Aug 20, 2024

Anki-Android-Backend hasn't gotten the excellent feature forward-port of putting all version information in a libs.versions.toml file, so we have versions scattered everywhere

First step should be to consolidate versions into that single file, then the NDK install could reference the file - even from workflow .yml scripts and shell scripts etc it is trivial to parse the toml file and dynamically pull the version, so the NDK version is only defined in one spot

The README file should be altered at the same time to link to the toml file instead of referencing the version directly as it does not

Originally posted by @mikehardy in #402 (comment)

@mikehardy mikehardy added help wanted Extra attention is needed Dev labels Aug 20, 2024
@voczi
Copy link
Contributor

voczi commented Nov 3, 2024

Re-visting this and #406 when NDK28 is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants