From db12085d4c67e6688aa2f975d05783253eb06b5d Mon Sep 17 00:00:00 2001 From: Timo Glastra Date: Wed, 27 Nov 2024 16:47:53 +0100 Subject: [PATCH 1/3] fix: deeplinking if walelt is open ios Signed-off-by: Timo Glastra --- apps/easypid/src/app/+native-intent.tsx | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/apps/easypid/src/app/+native-intent.tsx b/apps/easypid/src/app/+native-intent.tsx index 60e24862..ad6ad2c2 100644 --- a/apps/easypid/src/app/+native-intent.tsx +++ b/apps/easypid/src/app/+native-intent.tsx @@ -4,7 +4,6 @@ import { parseInvitationUrl } from '@package/agent' import { deeplinkSchemes } from '@package/app' import * as Haptics from 'expo-haptics' import { router } from 'expo-router' -import { Platform } from 'react-native' export async function redirectSystemPath({ path, initial }: { path: string; initial: boolean }) { const isRecognizedDeeplink = deeplinkSchemes.some((scheme) => path.startsWith(scheme)) @@ -13,7 +12,6 @@ export async function redirectSystemPath({ path, initial }: { path: string; init try { const parseResult = await parseInvitationUrl(path) if (!parseResult.success) { - void Haptics.notificationAsync(Haptics.NotificationFeedbackType.Error) return '/' } @@ -32,10 +30,10 @@ export async function redirectSystemPath({ path, initial }: { path: string; init } if (redirectPath) { - // NOTE: on android it somehow doesn't handle the intent if the app is already open + // NOTE: it somehow doesn't handle the intent if the app is already open // so we replace the router to the path. I think it can break easily though if e.g. // the wallet is locked in the background. Not sure how to proceed, this is best effort fix - if (Platform.OS === 'android' && !initial) { + if (!initial) { router.replace(redirectPath) return null } From 4c2f3c1a1d0cb0d9825844bb44ebb5ac66cf389d Mon Sep 17 00:00:00 2001 From: Timo Glastra Date: Wed, 27 Nov 2024 16:49:17 +0100 Subject: [PATCH 2/3] docs: update changelog Signed-off-by: Timo Glastra --- apps/easypid/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/easypid/README.md b/apps/easypid/README.md index 49e6e245..77b21d3c 100644 --- a/apps/easypid/README.md +++ b/apps/easypid/README.md @@ -392,6 +392,7 @@ The following standards and specifications were implemented. **Wallet** - Fixed an issue with the app locking in the background [commit](https://github.com/animo/paradym-wallet/commit/6d5e2f176d32328e834b293c3389780fd9ca3d91) +- Fixed an issue where deeplinking didn't work on iOS if the wallet is already unlocked [commit](https://github.com/animo/paradym-wallet/commit/db12085d4c67e6688aa2f975d05783253eb06b5d) ### Phase 1 From 90212642c465054ca50a2b105f6d3ae12e8a4015 Mon Sep 17 00:00:00 2001 From: Timo Glastra Date: Wed, 27 Nov 2024 16:50:42 +0100 Subject: [PATCH 3/3] docs: update known bugs Signed-off-by: Timo Glastra --- apps/easypid/README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/apps/easypid/README.md b/apps/easypid/README.md index 77b21d3c..7e7f0169 100644 --- a/apps/easypid/README.md +++ b/apps/easypid/README.md @@ -375,7 +375,6 @@ The following standards and specifications were implemented. ## Known Bugs - Entering incorrect PIN during presentation sharing will get stuck on the PIN loading screen (it does show correct PIN invalid toast). -- The navigation when re-opening the app is broken. And also deeplinking does not work when the app is already open. This is quite impactful as it means you have to force close the app sometimes. - You have to force close the app when you use BLE for the first time after enabling location permission because the permission popup does not go away. ## Changelog