MSVC error about APIENTRY when including windows.h after epoxy/gl.h

[benjamin-otte]

In my adventure to compile GTK with VS Code, I turned on --werror today, and I got this:

C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\shared\minwindef.h(130): error C2220: the following warning is treated as an error
C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\shared\minwindef.h(130): warning C4005: 'APIENTRY': macro redefinition
C:\Users\company\git\gtk\subprojects\libepoxy\include\epoxy/gl.h(59): note: see previous definition of 'APIENTRY'

This happens because Windows and GL incldues are sprinkled all over the GTK codebase and sometimes a source file ends up including both in some unpredictable order.

I'm sure you're aware that APIENTRY is defined in WinDef.h.

So I'm wondering if I should work around this in GTK (by including WinDef.h before any gl.h include) or if epoxy should do something like include it or if it should #undef APIENTRY at the end or something like it.

[ebassi]

This is #294