Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 9 support #111

Open
2 of 9 tasks
kirillgroshkov opened this issue Feb 15, 2020 · 5 comments
Open
2 of 9 tasks

Angular 9 support #111

kirillgroshkov opened this issue Feb 15, 2020 · 5 comments

Comments

@kirillgroshkov
Copy link

This is a...

  • feature request
  • bug report
  • usage question

What toolchain are you using for transpilation/bundling?

  • @angular/cli
  • Custom @ngTools/webpack
  • Raw ngc
  • SystemJS
  • Rollup
  • Other

Would be nice to have Angular 9 support.

@maplion
Copy link

maplion commented Feb 19, 2020

@kirillgroshkov I'm currently using angular-redux/store 10.0.0 with Angular 9 and not having any issues. What issues are you having?

@kirillgroshkov
Copy link
Author

Not 100% sure it's related to angular-redux, but after updating to Angular 9 I see this:

image

image

@maplion
Copy link

maplion commented Feb 23, 2020

@kirillgroshkov Ah yes, I was able to fix that issue by installing the library redux-observable-es6-compat https://github.com/iwnow/redux-observable-es6-compat

Then update your import statement in your app or core module for createEpicMiddleware

import { createEpicMiddleware } from 'redux-observable-es6-compat';

Then that should be made part of your store configuration, something like this (only relevant parts shown):

const epicMiddleware = createEpicMiddleware();
const middlewares: any = [epicMiddleware, <any other middlewares, e.g. reduxCatch>];
const enhancers: any = [];
const middlewareEnhancer = applyMiddleware(...middlewares);
enhancers.push(middlewareEnhancer);
composedEnhancers = composeEnhancers(...enhancers);
const store = createStore(rootReducer, initialState, composedEnhancers);

Try it out and let me know if it resolves your issue.

@asvishnyakov
Copy link

Related to #90

@maplion
Copy link

maplion commented Mar 22, 2020

@asvishnyakov Do you know if anyone is working on this project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants