Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Improvement: More dynamic Reader and Writer #7

Open
anergictcell opened this issue Sep 21, 2022 · 0 comments
Open

Code Improvement: More dynamic Reader and Writer #7

anergictcell opened this issue Sep 21, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@anergictcell
Copy link
Owner

Currently, a lot of functionality for the different Reader and Writer is based on <File> and thus quite restricted.
Rework the Reader and Writer structs for all modules to be more generic, e.g. require Read + Seek etc.

This would enable clients to be more dynamic in input and output data. For example, one could use an S3-based reference genome and ATGlib would only read the required sections, not have to download the full reference genome. It would also allow streaming from/to S3. (use https://crates.io/crates/s3reader)

@anergictcell anergictcell changed the title More dynamic Reader and Writer Code Improvement: More dynamic Reader and Writer Sep 22, 2022
@anergictcell anergictcell added the good first issue Good for newcomers label Sep 24, 2022
anergictcell added a commit that referenced this issue Oct 7, 2022
FastaReader can now use any Read + Seek implementer as an internal reader. The old version only allowed File based readers, but now clients can use more abstract readers, e.g. via HTTP or directly from an S3 bucket using S3Reader.
Relates to #7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant