Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parso scopes to correctly determine if non top level types are in scope #15

Open
anentropic opened this issue Mar 31, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@anentropic
Copy link
Owner

Currently we find all the imports and class defs in the module and treat them as all "in scope" for any annotated function

So there are some edge cases where we would fail to auto-add an import because we treated a non-top-level classdef or import elsewhere in the module as in-scope, whne it wasn't

It looks like Parso is able to keep track of variable scopes in its parse tree... so we could potentially "get this right", just at the cost of even more complication in our auto-import logic...

@anentropic anentropic added the enhancement New feature or request label Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant