Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mix Deps.Add #1

Open
andyl opened this issue May 27, 2021 · 0 comments
Open

Mix Deps.Add #1

andyl opened this issue May 27, 2021 · 0 comments

Comments

@andyl
Copy link
Owner

andyl commented May 27, 2021

From twitter:

@hauleth
Unfortunately, even with this, implementing mix deps.add in a foolproof way is impossible.

  • what if :deps is list within config/0?
  • what if it is module attribute instead of function?
  • what if there is no :deps key in config/0
  • what if :deps call function defined in another file?

Due to fact that mix.exs is executable it is hard.

That would be good enough for an external library then. Built in tool should work in 100% of the cases.

@AmNicd
I don't agree. You can make it bail out and give a good error message explaining why. If you've moved your deps away from the default, you're already probably experienced enough to deal with it. This is letting niche use cases prevent usability improvements from the majority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant