Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note bends [via Reddit] #4

Open
Jamedjo opened this issue Apr 30, 2014 · 5 comments
Open

Note bends [via Reddit] #4

Jamedjo opened this issue Apr 30, 2014 · 5 comments
Labels

Comments

@Jamedjo
Copy link
Collaborator

Jamedjo commented Apr 30, 2014

It really needs bend indicators for learning lead parts; it just seems to show the unbent note.

http://www.reddit.com/r/rocksmith/comments/24cd0u/rocksmith_tab_explorer_github/ch5zl57

@andulv
Copy link
Owner

andulv commented May 4, 2014

I have added support for bended notes. It seems to work for the (few) cases I have tested with. But I will be surprised if is correct for all variations of bends that may exist.

Please report any bugs found, together with what the correct result should have been.

@apelliciari
Copy link

bends are not working on v0.0.4.0

taking an example: Queen - We are the champions (Lead), beat 30-31-32 http://i.imgur.com/8o08vh0.png

No bends in the sheet, but actually there are a lot of bends in there ( see http://youtu.be/lqX0SClIv-c?t=1m53s )

@Jamedjo Jamedjo added the Bug label May 7, 2014
@andulv
Copy link
Owner

andulv commented May 7, 2014

My comment was a bit unprecise. I just commited the code that supports bended notes. The new version with this feature was not yet released when I wrote the comment above.

But now Jamedjo has prepared v0.0.5.0, where this feature should be included. Please test and give feedback!

@apelliciari
Copy link

Hi andulv,

i've tried with 0.0.5.0, but no bends yet :(

see the screenshot, same song and beats above http://i.imgur.com/hOQmMiM.png

@andulv
Copy link
Owner

andulv commented May 15, 2014

I have found the issue, and will probably get it fixed or find a workaround one of the next days.

It seems like AlphaTab (the component that we use to render the tablature) ignores bends where the bend starts immediately when the note is played. (Bend is at offset 0.0 from starttime of the note)

Bended notes that start out on the original note and then is bent after some time seems to render correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants