Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Signature (& Dotted Notes) #11

Open
Jamedjo opened this issue May 7, 2014 · 1 comment
Open

Time Signature (& Dotted Notes) #11

Jamedjo opened this issue May 7, 2014 · 1 comment
Labels

Comments

@Jamedjo
Copy link
Collaborator

Jamedjo commented May 7, 2014

The time signature can jump around quite a bit as in Stone by Alice In Chains below. It doesn't match the notes in some of those bars too. (Also, dotted notes haven't been implemented yet.)

screenshot-p149

@Jamedjo Jamedjo added the Bug label May 7, 2014
@andulv
Copy link
Owner

andulv commented May 7, 2014

The code for determining time signature just counts the number of following ebeats for each numbered ebeat (measure) in the Rocksmith file.

From the songs I tested with, it seemed like the numbers of ebeats for a measure indicated the time signature, but from the example above it seems like this is not always the case.

Also, when converting each individual note the code is still hardcoded to use 4/4 time. I will try to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants