Skip to content
This repository has been archived by the owner on Dec 11, 2021. It is now read-only.

Regression: getting lots of detached plain text copies where HTML is perfectly OK #106

Open
andrewferrier opened this issue Aug 24, 2016 · 2 comments
Labels

Comments

@andrewferrier
Copy link
Owner

No description provided.

@andrewferrier
Copy link
Owner Author

andrewferrier commented Sep 11, 2016

Looks like we may not be correctly handling emails with multipart/alternative, e.g.:

 I     1 <no description>                                                                          [multipa/alternativ, 7bit, 38K]
  I     2 ├─><no description>                                                                  [text/plain, quoted, us-ascii, 1.8K]
  I     3 └─><no description>                                                                            [multipa/mixed, 7bit, 36K]
  I     4   ├─><no description>                                                                   [text/html, 7bit, us-ascii, 3.4K]
  A     5   ├─>XXX.PDF                                                                               [applica/pdf, base64, 32K]
  I     6   └─><no description>                                                                   [text/html, 7bit, us-ascii, 0.2K]

@andrewferrier
Copy link
Owner Author

Plan to resolve:

  • Write tests to support multipart/alternative to validate failure (e.g. the one in the comment above fails).
  • Fix email2pdf to support multipart/alternative messages, selecting HTML in preference, then plain text. Should always handle all non-HTML/plain text attachments, though.

andrewferrier pushed a commit that referenced this issue Nov 5, 2016
This reverts commit b9dff29. This is a
temporary change until issue #106 is resolved since at the moment it's
creating lots of stray attachments.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant