Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: game action buttons do not disappear when game manually stops #670

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

andrew-codes
Copy link
Owner

Includes removal of blackout in visual tests in favor of hiding text and other elements.

Closes #669

Includes removal of blackout in visual tests in favor of hiding text and other elements.
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 88.63636% with 5 lines in your changes missing coverage. Please review.

Project coverage is 61.06%. Comparing base (0d1a471) to head (6f2772f).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...er/mqttUpdater/handlers/persistGameReleaseState.ts 0.00% 3 Missing ⚠️
apps/playnite-web/src/queryHooks/startRelease.ts 94.73% 1 Missing ⚠️
apps/playnite-web/src/queryHooks/stopRelease.ts 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #670      +/-   ##
==========================================
+ Coverage   60.15%   61.06%   +0.91%     
==========================================
  Files          98       98              
  Lines        1930     1970      +40     
  Branches      433      430       -3     
==========================================
+ Hits         1161     1203      +42     
+ Misses        761      711      -50     
- Partials        8       56      +48     
Flag Coverage Δ
component-tests 36.04% <ø> (ø)
e2e-tests 73.81% <92.85%> (+1.04%) ⬆️
unit-tests 9.32% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrew-codes andrew-codes merged commit 04f9189 into main Dec 12, 2024
8 checks passed
@andrew-codes andrew-codes deleted the 669 branch December 12, 2024 20:39
github-actions bot pushed a commit that referenced this pull request Dec 12, 2024
# [10.1.0](v10.0.2...v10.1.0) (2024-12-12)

### Features

* game action buttons do not disappear when game manually stops ([#670](#670)) ([04f9189](04f9189)), closes [#669](#669)
Copy link

🎉 This PR is included in version 10.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done ✅
Development

Successfully merging this pull request may close these issues.

Do not update game actions based on Playnite game state
1 participant