Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save word embeddings into Documents folder #169

Open
hunterprice04 opened this issue Oct 13, 2020 · 7 comments
Open

Save word embeddings into Documents folder #169

hunterprice04 opened this issue Oct 13, 2020 · 7 comments
Labels
feature For major features to be implement Priority Low Not so important

Comments

@hunterprice04
Copy link
Contributor

Downloads the files into a hidden a hidden folder titled .lefdict

@hunterprice04 hunterprice04 added feature For major features to be implement Priority Low Not so important labels Oct 13, 2020
@andreicozma1
Copy link
Owner

@hunterprice04 perhaps we can change this issue like this:
Instead of saving per-workspace (which would waste space), maybe we can figure out how to save it to a persistent directory internal to PyQT?
User will have option to either save externally on disk or internally with pyqt settings. Maybe QSettings has some kind of helper function for saving persistent files, not just preferences?

Please change the title of this issue according to the new implementation

@hunterprice04
Copy link
Contributor Author

@andreicozma1 I will look into the PyQT settings more when I have time to work on this issue. I will keep you updated.

@andreicozma1
Copy link
Owner

@andreicozma1 I will look into the PyQT settings more when I have time to work on this issue. I will keep you updated.

Sounds good! For now just change the title to more closely resemble what we'll try to accomplish with this feature so we don't forget about it

@andreicozma1
Copy link
Owner

@hunterprice04 may not be needed to save per-workspace anymore since saving it in one place is preferrable
If we can figure out how to always save it to the persistent directory such as the one used for QSettings we can implement that for this issue. That way the user doesn't have to choose where to save those dictionaries

@hunterprice04
Copy link
Contributor Author

@andreicozma1
I've found this package to return the user's application data directory. Could this work?
https://pypi.org/project/appdirs/

I've also found this approach to the problem as well.
https://stackoverflow.com/questions/19078969/python-getting-appdata-folder-in-a-cross-platform-way

I've also seen many applications save the application data into the home directory as a hidden file.

Let me know what way you prefer and I can attempt a solution.

@hunterprice04 hunterprice04 changed the title Option to download the summarizer dictionaries per workspace Save app data into persistent directory Nov 2, 2020
@hunterprice04 hunterprice04 self-assigned this Nov 2, 2020
@hunterprice04 hunterprice04 changed the title Save app data into persistent directory Save word embeddings into app data Nov 4, 2020
hunterprice04 added a commit that referenced this issue Nov 4, 2020
@hunterprice04 hunterprice04 linked a pull request Nov 4, 2020 that will close this issue
Closed
hunterprice04 added a commit that referenced this issue Nov 4, 2020
@jisber
Copy link
Contributor

jisber commented Nov 5, 2020

When I click Enable Summerizer->yes, the program doesn't crash but here is the error I am getting.

image

@hunterprice04
Copy link
Contributor Author

When I click Enable Summerizer->yes, the program doesn't crash but here is the error I am getting.

image

@jisber a quick fix to this is to simply shut down your computer, load into bios, delete your windows 10 installation, and get a better OS.

hunterprice04 added a commit that referenced this issue Nov 5, 2020
hunterprice04 added a commit that referenced this issue Nov 6, 2020
hunterprice04 added a commit that referenced this issue Nov 6, 2020
@hunterprice04 hunterprice04 changed the title Save word embeddings into app data Save word embeddings into Documents folder Nov 8, 2020
@hunterprice04 hunterprice04 added this to the Stage 5 milestone Nov 9, 2020
hunterprice04 added a commit that referenced this issue Nov 10, 2020
@hunterprice04 hunterprice04 removed this from the Stage 5 milestone Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature For major features to be implement Priority Low Not so important
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants