aligning a selection of cell's cause crash (on NixOS)

[mipmip]

Sc-im crashes with buffer overflow when trying ot align a visual selection.

*** buffer overflow detected ***: terminated
[1]    1081326 IOT instruction (core dumped)  sc-im

sc-im-align-selection-crash.mp4

[andmarti1424]

Hello. Will check it out. Thank you for reporting this.

[andmarti1424]

I am not able to reproduce this. Can someone test this and report back? @mipmip are you able to make it crash every time? Thanks.

[mipmip]

@mipmip are you able to make it crash every time? Thanks.

Yes. Visual select + aligning = crash

[andmarti1424]

That is what I did, but no crash in here I am afraid.
EDIT: I have also tested it with valgrind to see if there is an overflow or leak but I saw none

[mipmip]

It seems to happen here: visual.c > line 510: swprintf(interp_line + wcslen(interp_line), BUFFERSIZE, L":%s", v_name(r->brrow, r->brcol));

I'll test it on other machines tomorrow.

[mipmip]

When the gcc option -D_FORTIFY_SOURCE=2 is set this make sc-im crash. Unfortunately I haven't found the real fix, but I guess sc-im isn't ready for -D_FORTIFY_SOURCE=2.

In Nix the build option hardeningDisable = [ "fortify" ]; fixes this problem. Other distro's might have this problem.

[andmarti1424]

@mipmip will try to build it like that and retry with valgrind.

[mipmip]

This answer seems relevant https://stackoverflow.com/questions/68496582/swprintf-with-d-fortify-source-2-throws-a-buffer-overflow

[mipmip]

in NixOS issue and PR are filed:

• sc-im: aligning a selection of cell's cause crash NixOS/nixpkgs#335130
• sc-im: aligning a selection of cells cause crash NixOS/nixpkgs#335133

[jtraeholt]

might be related. :cellcolor crashes too