Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: ML Tooling can't handle models with no y values #263

Closed
2 tasks done
andersbogsnes opened this issue Sep 10, 2019 · 2 comments
Closed
2 tasks done

BUG: ML Tooling can't handle models with no y values #263

andersbogsnes opened this issue Sep 10, 2019 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@andersbogsnes
Copy link
Owner

If we have a model that has no y values when training, ML-tooling will fail, as it always does a train_test_split which fails when y is None.

To Reproduce
Steps to reproduce the behavior:

  1. Define a model where y=None
class RandomRankEstimator(BaseEstimator, ClassifierMixin):
    def fit(x, y=None):
          ... do modelstuff here...
    def predict(x):
        ...predict...

class CovRanker(ModelData):
       def get_training_data():
             return x, None
       def get_prediction_data(x):
            return x

model = CovRanker(RandomRankEstimator)
model.train_estimator()

Expected behavior
.train_estimator should not fail if no y value is supplied

Additional context
Add any other context about the problem here.

  • I have updated ML Tooling to the latest version
  • I have checked if this issue has been reported previously
@andersbogsnes andersbogsnes added the bug Something isn't working label Sep 10, 2019
@andersbogsnes andersbogsnes added this to the 0.8.0 milestone Sep 10, 2019
@thomasfrederikhoeck
Copy link
Contributor

Could be solved in #275

@andersbogsnes andersbogsnes mentioned this issue Dec 2, 2019
4 tasks
@andersbogsnes
Copy link
Owner Author

solved by #348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants