Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging package does not consider UNKNOWN version stubs #3594

Open
wagoodman opened this issue Jan 16, 2025 · 0 comments
Open

Merging package does not consider UNKNOWN version stubs #3594

wagoodman opened this issue Jan 16, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@wagoodman
Copy link
Contributor

Today the pkg.Collection can merge packages that have the same package ID, which is based on the values within all fields on pkg.Package recursively. The downside with this approach is that it does not allow for packages that with UNKNOWN versions to be merged with other packages found by other catalogers which might have more accurate information (e.g. binary cataloger vs go binary cataloger). The reason why package cannot be merged today is because the IDs are guaranteed to be different, since the version field is one of the fields that affects the package ID and the versions in this scenario are guaranteed to be different.

Should we attempt to merge packages in this way?

@wagoodman wagoodman added the bug Something isn't working label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant