ADRV9009: Add Data Offload to ZC706 and ZCU102 platforms #2682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrDragomir
requested review from
nunojsa,
mhennerich,
dbogdan,
btogorean,
chegbeli,
buha,
amiclaus,
rbolboac,
danmois,
CiprianRegus and
machschmitt
as code owners
nunojsa
reviewed
Jan 3, 2025
| // adi,oneshot; | ||
| // adi,bypass; | ||
| // adi,sync-config = <2>; | ||
| // adi,transfer-length = /bits/ 64 <0x10000>; // 2**16 bytes |
There was a problem hiding this comment.
nit: I would remove code that´s commented... No point in keeping it. If you remove the above, you can also improve the commit title to keep the preferred style:
git log --oneline arch/arm/boot/dts
...
78938c031bef ARM: dts: socfpga_cyclone5_de10_nano*: Drop bogus address in unit name
abc5de225b4c ARM: dts: socfpga_cyclone5_de10_nano*: Cleanup fixed-clock definition
fe394b7ba488 ARM: dts: socfpga_cyclone5_de10_nano*: Drop leading zeros and hex prefix from node names
4474c4290363 ARM: dts: socfpga_cyclone5_de10_nano: Drop alias node
e82ea168cafc ARM: dts: socfpga_cyclone5_de10_nano: Align memory node to mainline usage
c2f0ec9c2dde ARM: dts: socfpga_cyclone5_de10_nano: Drop useless status = "okay" prop
12fdfa4b0448 ARM: dts: socfpga_cyclone5_de10_nano: Drop properties specific to U-Boot
9b90eed37554 ARM: dts: socfpga_cyclone5_de10_nano: Drop unused and undocumented properties
| // adi,bypass; | ||
| // adi,sync-config = <2>; | ||
| // adi,transfer-length = /bits/ 64 <0x10000>; // 2**16 bytes | ||
| }; |
There was a problem hiding this comment.
Same about commented code.... The more accurate commit title would be arm64: dts: xilinx: zcu102_adrv9009: ...
Add data offload in dts to support the new hdl changes in analogdevicesinc/hdl#1516 Signed-off-by: AndrDragomir <[email protected]>
Add data offload in dts to support the new hdl changes in analogdevicesinc/hdl#1516 Signed-off-by: AndrDragomir <[email protected]>
AndrDragomir
force-pushed
the
adrv9009_data_offload
branch
from
521d554 to
c3b4d4b
Compare
nunojsa
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
In the HDL design for adrv9009 with zc706, respectively zcu102, the DAC_FIFO component was replaced by Data Offload.
These devicetree changes were tested together with this PR: analogdevicesinc/hdl#1516
PR Type
PR Checklist