Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing_python_build_tool and missing_pip_check lints are possibly not relevant for all multi-output packages #299

Open
skupr-anaconda opened this issue Oct 16, 2023 · 1 comment
Open

missing_python_build_tool and missing_pip_check lints are possibly not relevant for all multi-output packages #299

skupr-anaconda opened this issue Oct 16, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@skupr-anaconda
Copy link
Contributor

I found that these errors are false positives for the multi-output packages if one of the outputs has pin_subpackage:

ERROR: clone/recipe/meta.yaml:68: missing_python_build_tool: output "cufflinks-py": Python packages require a python build tool such as setuptools.
ERROR: clone/recipe/meta.yaml:74: missing_pip_check: For pypi packages, pip check should be present in the test commands

Because we do not need setuptools to build it again and run pip check twice

See AnacondaRecipes/python-cufflinks-feedstock#2 (comment)
@schuylermartin45 schuylermartin45 added the bug Something isn't working label Nov 7, 2023
@schuylermartin45
Copy link
Collaborator

Tracking: https://anaconda.atlassian.net/browse/PAT-171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schuylermartin45 @skupr-anaconda