-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Free space check should respect symlinks #7
Comments
No it doesn't. Use the proper way to store your data in different locations - by editing |
People on the server won. I'll add real path resolution here in future versions |
I'm glad this is planned to be fixed. It seems I do not have enough Rust experience to create a PR sadly but https://doc.rust-lang.org/std/fs/fn.canonicalize.html looks like the right thing to use instead of anime-game-core/src/installer/free_space.rs Lines 23 to 25 in 0fb314b
|
Would this be the cause for an-anime-team/the-honkers-railway-launcher#143 ? |
Currently the free space check does not handle symlinks correctly
For example, if I have a symlink from
~/.local/anime-game-launcher
to/var/games/anime-game
and/var
is a different disk from/
, the free space check will incorrectly return the free space for/
.Probably this can be done by resolving the symlink to a real path before doing the mount point check
anime-game-core/src/installer/free_space.rs
Line 26 in 347a4ce
The text was updated successfully, but these errors were encountered: