Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native + attribute/cti #1363

Open
TrevorRice opened this issue Oct 8, 2024 · 1 comment
Open

React Native + attribute/cti #1363

TrevorRice opened this issue Oct 8, 2024 · 1 comment

Comments

@TrevorRice
Copy link

Hi all 👋

Was there a conscious decision to exclude attribute/cti from the react-native transform group? It is currently the only transform group that does not leverage the transform, which led to some initial confusion about why some of my filters weren’t behaving as expected across platforms.

If this was an oversight, could it be added to the transform group? I understand that this is easy to work around and presumably has some breaking change implications, but maybe it's worth considering in the next major for consistency across other groups.

Cheers!

@jorenbroekema
Copy link
Collaborator

I don't recall this to be a conscious decision, we'd have to dig through git blames to find which PR added the transformGroup, in v3 it was also there without the attribute/cti.

If it was an oversight, then I'm definitely down to add "attribute/cti" so it's consistent with the others, I would consider that a bugfix then which I'm okay with putting in v4 even if it is technically a small breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants