Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs incorrectly describe createNotifier() as a middleware #7

Open
markerikson opened this issue May 17, 2018 · 1 comment
Open

Docs incorrectly describe createNotifier() as a middleware #7

markerikson opened this issue May 17, 2018 · 1 comment

Comments

@markerikson
Copy link

The docs say that ReactPerformance.createNotifier() returns a "middleware", but it actually creates a Redux store enhancer instead, which is why it needs to be passed to compose() instead of passed to applyMiddleware(). This should be fixed for clarity.

@amsul
Copy link
Owner

amsul commented May 21, 2018

@markerikson true! I'd love a PR 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants