-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement AMP Stories #968
Comments
Yes, this has just been talked about for the next major version, |
Wanted to share what Mic product open sourced today. A story format in JSON. https://github.com/micnews/story-json Not suggesting that we detour to their format. But they have built something very cool on top of this: a story JSON to video tool. https://github.com/micnews/story-json-to-amp This could be a great feature for AMP WP too, or an extension plugin. |
Gutenberg dependencies (moved to description). |
Since AMP stories require that a singular |
Hi @davisshaver (great to see you at #wcpub, thanks for attending our workshop!!) and @westonruter:
|
@jwold - can you add your designs to this ticket? |
Howdy! Wanting to share an update to the work that @postphotos, @westonruter and I have been working on for the past couple of weeks. Last week we created a clickable prototype that outlines the following things:
You can view the prototype here: https://xd.adobe.com/view/a789ebeb-d577-4646-79f0-5db7bb4b5760-d1b8/ This assumes that all upstream dependencies (in the Gutenberg project as well as AMP itself) are unblocking this work. We'd love feedback on this. @miina and @westonruter have started development work this week on implementing the features listed in the prototype. You can see updates to the PR on #1215 and #1347 We're considering gathering user feedback based on the proposed UI so far. From a UI perspective there are still items to work through, including the animations. We'll followup here with the next update. cc @amedina |
Super exciting :). re: NUX, I had to google what a page/layer was in AMP Story format. Maybe the Gutenberg help tip UI could be extended to explain this on first use. |
@jwold I think the direction these designs are taking is excellent! I'd love to assist and lend my experience with the UI and animation aspects of this project. Let's connect later and discuss what that could look like! |
@Calebj7 that sounds great! The next big piece is to nail down the animation part. What do we want animation to look like, what's MVP, and what are ways we could improve it. |
Howdy folks! A few days ago I shared a link to an XD prototype, but would also like to include the .png files for easy reference. There are still some things to figure out, but this represents where we now stand on the UI.
|
Thanks a lot, @jwold, for sharing those mockups. Very cool work! The buttons on the bottom right — are those useful with the sidebar closed, or a different sidebar open? Or do they automatically open the sidebar if it's closed? If so, how does that work on mobile or in small responsive breakpoints? I love your mockups, and I love they involve the main canvas. This solution feels a very tailored specifically to AMP stories, though — which is perfectly fine, but that means it should be implemented on a per-block basis. The reason I'm asking is because I'm looking for a solution that makes it easy to manage nested blocks for any block that has nested blocks, not just AMP Stories, and in this case the UI while intuitive for a very tall block seems to scale less to less tall blocks. One of the things I explored in WordPress/gutenberg#9053 (comment) was the complete reliance on the sidebar for managing layers. The idea being that you can use the block without opening the sidebar, but advanced configuration requires it. That gives a little more space to work with sub-blocks/layers/child blocks. Brainstorming a bit, another thing the block level allows us to, is to show additional content below the block when selected. Here's a dirty sketch: Essentially when the block is not selected, you'd see more or less a preview of the block itself. As soon as you select it, you can see any child-blocks linked as "tabs" or quick thumbnails below, which you can then select to configure. Deselect the block again to preview. Another option is to us a modal for this — add a button to the toolbar of any block that has child blocks and opt into this advanced selection mode. Then you can open the modal to manage layers/child blocks. What do you think? |
Hi, @jasmussen, thanks for your comments. On implementation of the buttons on the bottom right: At this moment the idea is to implement the buttons on the bottom right as part of the nested root block ( |
ISSUE 1: As a WordPress author, I need to be able to manage content for AMP stories using Gutenberg.
Key PR: #1215
AMP Dependencies
Gutenberg Dependencies
allowed_block_types
filter WordPress/gutenberg#6208Resources
The text was updated successfully, but these errors were encountered: