Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behavior when pressing the delete / backspace key in AMP Story editor #3280

Closed
spacedmonkey opened this issue Sep 17, 2019 · 5 comments
Labels
Accessibility Changes that impact accessibility and need corresponding review (e.g. markup changes). Bug Something isn't working

Comments

@spacedmonkey
Copy link
Contributor

When a block is selected and delete key is pressed, sometimes a block is not remove / deleted. This leads to press the delete key multiple times, that then deletes the page block. Generally the bahavior of the delete key in the AMP Story editor, should be handled better for accessibility reasons.

@spacedmonkey spacedmonkey added Bug Something isn't working AMP Stories Accessibility Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Sep 17, 2019
@MackenzieHartung MackenzieHartung added this to the v1.3.1 milestone Sep 18, 2019
@spacedmonkey
Copy link
Contributor Author

See this screenshot that show the errors.

https://www.youtube.com/watch?v=hvf0jOYe4Dg&feature=youtu.be

This screenshot shows two different two different errors.

  1. When blocks are selected, the delete and backspace key are being pressed and the block is not removed.
  2. When no block is selected and delete key is pressed, the whole page including of it's block is removed. But this only happens sometimes. It also means that the first page is removed, which is something that shouldn't be possible.

@spacedmonkey spacedmonkey changed the title Unexpected behavior when pressing the delete key in AMP Story editor Unexpected behavior when pressing the delete / backspace key in AMP Story editor Sep 27, 2019
@westonruter
Copy link
Member

I just noticed this behavior today when testing. I was surprised that pressing delete would not remove a selected block. I had to use the context menu to remove the block. (I could have used the Gutenberg shortcut, but I don't have it memorized.)

@spacedmonkey
Copy link
Contributor Author

Removing blocks / pages is not simple at the moment. I have created two related issues #3279 #3221

@spacedmonkey
Copy link
Contributor Author

As a talking point, I have created a WIP pull request in #3400. It is still discovery stages at this point, but it is a workable solution.

@swissspidy swissspidy modified the milestones: v1.3.1, v1.4 Oct 17, 2019
@jauyong
Copy link

jauyong commented Oct 30, 2019

@spacedmonkey @westonruter
I added different block types and only the text block failed to be deleted. Is this what you are experiencing as well?

Although it looks like I'm struggling to delete the CTA, that was just me. I tested and it was pretty seamless.

3280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Changes that impact accessibility and need corresponding review (e.g. markup changes). Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants