Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved “single error” by URL view #1365

Closed
10 tasks done
postphotos opened this issue Aug 27, 2018 · 10 comments
Closed
10 tasks done

Improved “single error” by URL view #1365

postphotos opened this issue Aug 27, 2018 · 10 comments
Labels
Milestone

Comments

@postphotos
Copy link
Contributor

postphotos commented Aug 27, 2018

As a developer using the AMP for WordPress plugin, I should have improved organization of errors that occur by error type.

  • AC1: Implement the new design linked below. This sunsets the "accordion" layout and introduces a "table" layout for single URL error listings.

    • Allow errors to be collapsable (and expandable).
    • Incorporate the new "Sources" layout.
    • Incorporate the new "Error Type" column.
    • respect "stale" errors as discussed elsewhere.
  • AC2: Incorporate facets by "Error Type" so that a developer could see just errors by Javascript for a given single URL, for example.

  • AC3: Also Incorporate search to manipulate which errors are shown in the table listing. Search would appear above the table.

  • AC4: Allow for bulk actions to accept, reject and delete errors on a per-error basis.

  • AC5: Continue to provide a full stack trace information/error dump in the form of a collapsible blob, as shown on the mockups and currently implemented as of v1.0-beta2.

  • AC6: Provide extended "status" information

Based on the new screen described here here here Final Designs: [ Page 1 ] [ Page 2 ], additional actions and an improved UI will allow a developer to better understand what errors occur on a per-URL basis and how to quickly action to suppress errors if they choose to do so.

The UI includes organizing the error blocks and provides a link to the appropriate place for the given user to understand how to best action to resolve the error long term, likely using the taxonomic data from #1360 to connect to relevant pages from amproject.org or ampbyexample.com or our documentation.

@postphotos postphotos added this to the v1.0 milestone Aug 27, 2018
@postphotos
Copy link
Contributor Author

@jwold @jillchu - I'd also like your thoughts on how to surface @kienstra's comment here to benefit this ticket as it hasn't been discussed yet and we shouldn't lose this feature in the new version of single error views.

@postphotos
Copy link
Contributor Author

postphotos commented Sep 4, 2018

As discussed in today's backlog grooming call, this screen's intention is to

  • give clear details for a single URL (and all its error occurrences)
  • Give them a way to action on singular or multiple errors
  • Give them a way to stage errors in preview (as currently available to a user in the current version of the plugin)

@kienstra
Copy link
Contributor

kienstra commented Sep 8, 2018

In Progress

I'm working on this (1365) now, on this branch.

@kienstra
Copy link
Contributor

kienstra commented Sep 11, 2018

Question About Latest Designs

Hi @postphotos,
Are these these the latest designs for the single URL page?

Thanks 😄

@postphotos
Copy link
Contributor Author

Hi @kienstra - yes, and I've updated the story! Missed this ticket. 🥇

@postphotos
Copy link
Contributor Author

@kienstra - per our call today, can you sync with @jillchu @jwold for design QA here?

@kienstra
Copy link
Contributor

Sure, @postphotos!

@kienstra
Copy link
Contributor

kienstra commented Sep 25, 2018

Request For Testing

Hi @csossi,
Could you please test the single error URL page (like this) against this issue's ACs and the design?

Please use this staging site, as it has the latest corrections from PR #1462.

And please see this screencast for the expected functionality of this page.

@csossi
Copy link

csossi commented Sep 26, 2018

Verified in QA

Assumption here is that tooltip positioning is a separate issue logged elsewhere

@kienstra
Copy link
Contributor

Hi @csossi,
Thanks for testing this.

Assumption here is that tooltip positioning is a separate issue logged elsewhere

Yes, the tooltips are in #1400.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants