Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow remote internal http.Client to be configured. #28

Closed
hbiarge opened this issue Aug 8, 2024 · 2 comments · Fixed by #29
Closed

Allow remote internal http.Client to be configured. #28

hbiarge opened this issue Aug 8, 2024 · 2 comments · Fixed by #29
Labels

Comments

@hbiarge
Copy link
Contributor

hbiarge commented Aug 8, 2024

The current implementation of the remote.Initialize function does not allow to configure the internal http.Client.

I would like to wrap this client to allow instrumentation of the remote http calls of the SDK.

Can you consider a way to easily instrument the internal client? May be passing a wrapped client in the config?

Thanks!

@hbiarge
Copy link
Contributor Author

hbiarge commented Aug 9, 2024

As I said in the PR, we can instrument the underlying RounTripper, but need to pass the current context to the Fetch and FetchV2 methods.

Copy link

🎉 This issue has been resolved in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant