Improve navigation cpp #1061
Open
Improve navigation cpp #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyAn84
force-pushed
the
improve_navigation_cpp
branch
10 times, most recently
from
6d31502
to
221acc1
Compare
CyAn84
force-pushed
the
improve_navigation_cpp
branch
2 times, most recently
from
d12a16d
to
63cadb3
Compare
CyAn84
force-pushed
the
improve_navigation_cpp
branch
from
63cadb3
to
0fcfa0c
Compare
CyAn84
force-pushed
the
improve_navigation_cpp
branch
from
0fcfa0c
to
040b8f8
Compare
CyAn84
force-pushed
the
improve_navigation_cpp
branch
5 times, most recently
from
0f79ad5
to
78ec451
Compare
CyAn84
force-pushed
the
improve_navigation_cpp
branch
from
78ec451
to
39716d6
Compare
aiamnezia
reviewed
Oct 30, 2024
| contentHeight: col.implicitHeight + addSiteButton.implicitHeight + addSiteButton.anchors.bottomMargin + addSiteButton.anchors.topMargin | ||
| width: parent.width | ||
|
|
||
| height: 200 // TODO: Change to correct height |
There was a problem hiding this comment.
Suggested change
| height: 200 // TODO: Change to correct height | |
| anchors.bottom: addSiteButton.top |
aiamnezia
reviewed
Oct 30, 2024
| anchors.top: parent.top | ||
| anchors.left: parent.left | ||
| anchors.right: parent.right | ||
| property bool isFocusable: true | ||
|
|
There was a problem hiding this comment.
Suggested change
| ScrollBar.vertical: ScrollBar {} |
There was a problem hiding this comment.
The default behavior of the ScrollBar is not working correctly. To fix this, you can initialize the ScrollBar as an empty object. Qt will then set the necessary default values automatically.
CyAn84
force-pushed
the
improve_navigation_cpp
branch
2 times, most recently
from
850ab1c
to
7b0713b
Compare
aiamnezia
reviewed
Oct 31, 2024
| contentHeight: col.implicitHeight + addSiteButton.implicitHeight + addSiteButton.anchors.bottomMargin + addSiteButton.anchors.topMargin | ||
| width: parent.width | ||
|
|
||
| height: 200 // TODO: Change to correct height | ||
|
|
||
| enabled: root.pageEnabled |
There was a problem hiding this comment.
Suggested change
| enabled: root.pageEnabled | |
| enabled: root.pageEnabled | |
| reuseItems: true |
for optimization
CyAn84
force-pushed
the
improve_navigation_cpp
branch
from
433d02f
to
58b0e80
Compare
straightforward
CyAn84
force-pushed
the
improve_navigation_cpp
branch
from
6cfd50e
to
0620b45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still draft pull request since the transitions need to be fixed.
The idea of navigation is follow:
there are QML components which should be focused with property
isFocusablewith key Tab handlers,focusControllergoes through all visible components with this property.No need to describe the focus logic manually but the focus navigation algorythm is straightforward - from upper left to bottom right.