Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues after upgrade react-native v0.71 #319

Closed
Avinash-dev-code opened this issue Mar 8, 2023 · 8 comments
Closed

Issues after upgrade react-native v0.71 #319

Avinash-dev-code opened this issue Mar 8, 2023 · 8 comments

Comments

@Avinash-dev-code
Copy link

Describe the bug
Trying to upgrade to RN v0.71 but keep getting the following error

FAILURE: Build failed with an exception.

  • Where:
    Build file '/.../node_modules/react-native-mmkv-storage/android/build.gradle' line: 138

  • What went wrong:
    A problem occurred evaluating project ':react-native-mmkv-storage'.

Expected directory '/.../node_modules/react-native-mmkv-storage/android/../../../node_modules/react-native/android' to contain exactly one file, however, it contains no files.
To Reproduce
Steps to reproduce the behavior:

upgrade to RN v0.71
Rebuild react-native android
See error
Expected behavior
react-native-mmkv-storage should continue working on the latest version of RN.

Screenshots
If applicable, add screenshots to help explain your problem.

Platform Information:

OS: Android
React Native Version 0.71
Library Version 0.8.0
Gradle 7.5.1
Additional context
Add any other context about the problem here.

@Avinash-Gophygital
Copy link

@ammarahm-ed Please give me some solution

@anatooly
Copy link

anatooly commented Mar 9, 2023

# The `/android` folder inside `react-native`

Starting from React Native 0.71, we're not shipping the `/android` folder inside the React Native NPM package
anymore due to sizing constraints on NPM. The Android artifacts are distributed via Maven Central.
You can read more about it in this RFC:
https://github.com/react-native-community/discussions-and-proposals/pull/508

If you're a library author and you're manipulating the React Native .aar files, to extract headers,
extract `.so` files or do anything with it, you're probably doing something wrong. React Native
0.71 ships with all the necessary logic to let you consume it transparently by just using:

implementation("com.facebook.react:react-android")
// or to keep backward compatibility with older versions of React Native:
implementation("com.facebook.react:react-native:+")

You should consider refactoring your library code not to unzip/manipulate the React Native .aar files.

This README.md file is kept in this folder as some libraries are checking the existence of the `/android` folder
and failing user builds if the folder is missing.

@anatooly
Copy link

anatooly commented Mar 9, 2023

@ammarahm-ed Please give me some solution

Easy solution is change package & your code from react-native-mmkv-storage to react-native-mmkv

@Ahmedhamed77
Copy link

same problem here

@Ahmedhamed77
Copy link

@ammarahm-ed Please give me some solution

Easy solution is change package & your code from react-native-mmkv-storage to react-native-mmk

but this is another package :/

@anatooly
Copy link

@ammarahm-ed Please give me some solution

Easy solution is change package & your code from react-native-mmkv-storage to react-native-mmk

but this is another package :/

yeap, but what different if you find more faster storage and minimum changes in your code?) mrousavy/react-native-mmkv#100 (comment)

30 min changes or waiting fix... week, month, year)))

@ammarahm-ed
Copy link
Owner

@ammarahm-ed Please give me some solution

Easy solution is change package & your code from react-native-mmkv-storage to react-native-mmk

but this is another package :/

yeap, but what different if you find more faster storage and minimum changes in your code?) mrousavy/react-native-mmkv#100 (comment)

30 min changes or waiting fix... week, month, year)))

Actually it's not my fault but react-native's that broke building the libraries in RN 0.71.0 completely. week, month,year is an exaggeration and you always send a PR to fix the issue. Performance is same.

@ammarahm-ed
Copy link
Owner

Fixed in 0.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants