Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper key description in Readme file #159

Open
RajatSatashiya opened this issue Aug 19, 2023 · 0 comments
Open

Improper key description in Readme file #159

RajatSatashiya opened this issue Aug 19, 2023 · 0 comments

Comments

@RajatSatashiya
Copy link

This is the current description of the library:
"A native implementation of RSA key generation and encryption/decryption, sign/verify. Keychain implementation Implementation is in PKCS1"

This however is wrong because although
PKCS #1 is being generated for android, the key being generated for iOS devices is PKCS#8.
Now, rather than changing the readme, you should update your code to generate PKCS #8 key for android devices as it is the industry standard and easy to verify from backend (JAVA, Node.js, etc...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant