Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor get_xml_string function to handle non-existent paths #104

Closed
wants to merge 1 commit into from
Closed

Refactor get_xml_string function to handle non-existent paths #104

wants to merge 1 commit into from

Conversation

xela-95
Copy link
Member

@xela-95 xela-95 commented Nov 5, 2024 •
edited by github-actions bot
Loading

This PR refactors the get_xml_string function in std_model.py to increase its robustness with respect to non existent model paths.

📚 Documentation preview 📚: https://adam-docs--104.org.readthedocs.build/en/104/

@xela-95 xela-95 mentioned this pull request Nov 5, 2024
Closed
3 tasks
@xela-95
Copy link
Member Author

xela-95 commented Nov 6, 2024

Sorry, I realized that @flferretti had the same idea and had already opened it: #103.

@xela-95 xela-95 closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xela-95